Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(170)

Issue 1224863004: [bindings] expose @@toStringTag on interface prototypes (Closed)

Created:
5 years, 5 months ago by caitp (gmail)
Modified:
4 years, 11 months ago
Reviewers:
haraken, jsbell, adamk
CC:
blink-reviews, blink-reviews-bindings_chromium.org, vivekg_samsung, arv+blink, vivekg
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[bindings] expose @@toStringTag on interface prototypes Experimental approach (per https://www.w3.org/Bugs/Public/show_bug.cgi?id=28244#c2) --- Sets @@toStringTag as a data property on interface prototypes. This does not fix crbug.com/239915 --- but I think it's worth experimenting to see if we can get away with the simpler approach BUG=239915, v8:3502 LOG=N R=jsbell@chromium.org, haraken@chromium.org

Patch Set 1 : #

Patch Set 2 : 5 months later... #

Unified diffs Side-by-side diffs Delta from patch set Stats (+94 lines, -0 lines) Patch
M third_party/WebKit/Source/bindings/templates/interface_base.cpp View 1 1 chunk +3 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/V8SVGTestInterface.cpp View 1 1 chunk +3 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/V8TestException.cpp View 1 1 chunk +3 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/V8TestIntegerIndexed.cpp View 1 1 chunk +3 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/V8TestIntegerIndexedGlobal.cpp View 1 1 chunk +3 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/V8TestIntegerIndexedPrimaryGlobal.cpp View 1 1 chunk +3 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/V8TestInterface.cpp View 1 1 chunk +3 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/V8TestInterface2.cpp View 1 1 chunk +3 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/V8TestInterface3.cpp View 1 1 chunk +3 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/V8TestInterfaceCheckSecurity.cpp View 1 1 chunk +3 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/V8TestInterfaceConstructor.cpp View 1 1 chunk +3 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/V8TestInterfaceConstructor2.cpp View 1 1 chunk +3 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/V8TestInterfaceConstructor3.cpp View 1 1 chunk +3 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/V8TestInterfaceConstructor4.cpp View 1 1 chunk +3 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/V8TestInterfaceCustomConstructor.cpp View 1 1 chunk +3 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/V8TestInterfaceDocument.cpp View 1 1 chunk +3 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/V8TestInterfaceEmpty.cpp View 1 1 chunk +3 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/V8TestInterfaceEventInitConstructor.cpp View 1 1 chunk +3 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/V8TestInterfaceEventTarget.cpp View 1 1 chunk +3 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/V8TestInterfaceGarbageCollected.cpp View 1 1 chunk +3 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/V8TestInterfaceNamedConstructor.cpp View 1 1 chunk +3 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/V8TestInterfaceNamedConstructor2.cpp View 1 1 chunk +3 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/V8TestInterfaceNode.cpp View 1 1 chunk +3 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/V8TestInterfaceWillBeGarbageCollected.cpp View 1 1 chunk +3 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/V8TestNode.cpp View 1 1 chunk +3 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/V8TestObject.cpp View 1 1 chunk +3 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/V8TestSpecialOperations.cpp View 1 1 chunk +3 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/V8TestSpecialOperationsNotEnumerable.cpp View 1 1 chunk +3 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/V8TestTypedefs.cpp View 1 1 chunk +3 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/modules/V8TestInterface5.cpp View 1 1 chunk +3 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/modules/V8TestInterfacePartial.cpp View 1 1 chunk +3 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/platform/RuntimeEnabledFeatures.in View 1 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 18 (5 generated)
caitp (gmail)
PTAL --- As noted in the description, this is kind of an experimental approach. It's ...
5 years, 5 months ago (2015-07-06 23:47:22 UTC) #1
arv (Not doing code reviews)
I like. Can you add a layout test (preferable using test-harness)?
5 years, 5 months ago (2015-07-07 02:02:56 UTC) #5
caitp (gmail)
On 2015/07/07 02:02:56, arv wrote: > I like. > > Can you add a layout ...
5 years, 5 months ago (2015-07-07 02:44:35 UTC) #6
arv (Not doing code reviews)
On 2015/07/07 02:44:35, caitp wrote: > On 2015/07/07 02:02:56, arv wrote: > > I like. ...
5 years, 5 months ago (2015-07-07 15:20:37 UTC) #7
caitp (gmail)
On 2015/07/07 15:20:37, arv wrote: > On 2015/07/07 02:44:35, caitp wrote: > > On 2015/07/07 ...
5 years, 5 months ago (2015-07-07 15:22:52 UTC) #8
jsbell
FYI - I have a nearly identical CL at https://codereview.chromium.org/1017733003/ - but I'm happy to ...
5 years, 5 months ago (2015-07-07 16:54:31 UTC) #9
jsbell
On 2015/07/07 16:54:31, jsbell wrote: > FYI - I have a nearly identical CL at ...
5 years, 5 months ago (2015-07-07 16:56:22 UTC) #10
caitp (gmail)
On 2015/07/07 16:56:22, jsbell wrote: > On 2015/07/07 16:54:31, jsbell wrote: > > FYI - ...
5 years, 5 months ago (2015-07-07 17:04:10 UTC) #11
adamk
What does this need to move forward?
5 years, 4 months ago (2015-08-17 22:17:29 UTC) #13
caitp (gmail)
On 2015/08/17 22:17:29, adamk wrote: > What does this need to move forward? I think ...
5 years, 4 months ago (2015-08-21 20:57:04 UTC) #14
adamk
How would you feel about resurrecting this? We'd like to move away from [[Class]] internally ...
5 years ago (2015-12-16 15:14:46 UTC) #16
caitp (gmail)
On 2015/12/16 15:14:46, adamk wrote: > How would you feel about resurrecting this? We'd like ...
5 years ago (2015-12-16 15:41:39 UTC) #17
caitp (gmail)
5 years ago (2015-12-16 19:11:33 UTC) #18
On 2015/12/16 15:41:39, caitp wrote:
> On 2015/12/16 15:14:46, adamk wrote:
> > How would you feel about resurrecting this? We'd like to move away from
> > [[Class]] internally in v8, and getting the DOM on @@toStringTag is one of
the
> > main blockers to that.
> 
> Sounds good to me

New patch at https://codereview.chromium.org/1524363003

Powered by Google App Engine
This is Rietveld 408576698