Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(575)

Issue 1224843009: Revert of GN: Explicitly list out public headers in the blink_headers source_set (Closed)

Created:
5 years, 5 months ago by pdr.
Modified:
5 years, 5 months ago
CC:
esprehn, blink-reviews, brettw, dglazkov+blink
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Revert of GN: Explicitly list out public headers in the blink_headers source_set (patchset #2 id:20001 of https://codereview.chromium.org/1222673004/) Reason for revert: This patch is causing build failures: http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_gn_rel/builds/107230/steps/gn_check%20%28with%20patch%29/logs/stdio Original issue's description: > GN: Explicitly list out public headers in the blink_headers source_set > > This enables "gn check" to enforce that source files that #include > these headers also declare a dependency on them in GN. > > This also fixes "gn check" on Android from having errors like: > > ERROR at //components/autofill/content/renderer/autofill_agent.cc:45:11: Include not allowed. > ^-------------------------------------------- > It is not in any dependency of > //components/autofill/content/renderer:renderer > The include file is in the target(s): > //third_party/WebKit/public:blink_headers_java_enums_srcjar__generate_enum > which should somehow be reachable. > > BUG=367595 > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=198439 TBR=dpranke@chromium.org,esprehn@chromium.org,agrieve@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=367595 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=198520

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -509 lines) Patch
M public/BUILD.gn View 1 chunk +0 lines, -509 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
pdr.
Created Revert of GN: Explicitly list out public headers in the blink_headers source_set
5 years, 5 months ago (2015-07-08 17:59:46 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1224843009/1
5 years, 5 months ago (2015-07-08 18:00:05 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://src.chromium.org/viewvc/blink?view=rev&revision=198520
5 years, 5 months ago (2015-07-08 18:00:46 UTC) #3
agrieve
5 years, 5 months ago (2015-07-08 22:32:45 UTC) #4
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1228703004/ by agrieve@chromium.org.

The reason for reverting is: Re-landing now that
https://crrev.com/deb02768bf9805279461259119a845aa2c734e25 is landed (fixes the
gn check errors this introduced the first time around).

Powered by Google App Engine
This is Rietveld 408576698