Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1773)

Unified Diff: Source/core/xml/parser/XMLDocumentParser.cpp

Issue 1224823006: Fix virtual/override/final usage in Source/core/xml/. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/xml/parser/XMLDocumentParser.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/xml/parser/XMLDocumentParser.cpp
diff --git a/Source/core/xml/parser/XMLDocumentParser.cpp b/Source/core/xml/parser/XMLDocumentParser.cpp
index 27ae49426b1196f4ec67b2e4fcf3bda5daa461c6..a01f145b6f09edadcf993a591a0bb9dd1c1a5f4c 100644
--- a/Source/core/xml/parser/XMLDocumentParser.cpp
+++ b/Source/core/xml/parser/XMLDocumentParser.cpp
@@ -147,7 +147,7 @@ public:
}
}
- virtual ~PendingStartElementNSCallback()
+ ~PendingStartElementNSCallback() override
{
for (int i = 0; i < m_namespaceCount * 2; ++i)
xmlFree(m_namespaces[i]);
@@ -158,7 +158,7 @@ public:
xmlFree(m_attributes);
}
- virtual void call(XMLDocumentParser* parser) override
+ void call(XMLDocumentParser* parser) override
{
parser->startElementNs(m_localName, m_prefix, m_uri,
m_namespaceCount, const_cast<const xmlChar**>(m_namespaces),
@@ -178,7 +178,7 @@ private:
class PendingEndElementNSCallback final : public XMLDocumentParser::PendingCallback {
public:
- virtual void call(XMLDocumentParser* parser) override
+ void call(XMLDocumentParser* parser) override
{
parser->endElementNs();
}
@@ -192,12 +192,12 @@ public:
{
}
- virtual ~PendingCharactersCallback()
+ ~PendingCharactersCallback() override
{
xmlFree(m_chars);
}
- virtual void call(XMLDocumentParser* parser) override
+ void call(XMLDocumentParser* parser) override
{
parser->characters(m_chars, m_length);
}
@@ -215,7 +215,7 @@ public:
{
}
- virtual void call(XMLDocumentParser* parser) override
+ void call(XMLDocumentParser* parser) override
{
parser->processingInstruction(m_target, m_data);
}
@@ -229,7 +229,7 @@ class PendingCDATABlockCallback final : public XMLDocumentParser::PendingCallbac
public:
explicit PendingCDATABlockCallback(const String& text) : m_text(text) { }
- virtual void call(XMLDocumentParser* parser) override
+ void call(XMLDocumentParser* parser) override
{
parser->cdataBlock(m_text);
}
@@ -242,7 +242,7 @@ class PendingCommentCallback final : public XMLDocumentParser::PendingCallback {
public:
explicit PendingCommentCallback(const String& text) : m_text(text) { }
- virtual void call(XMLDocumentParser* parser) override
+ void call(XMLDocumentParser* parser) override
{
parser->comment(m_text);
}
@@ -260,7 +260,7 @@ public:
{
}
- virtual void call(XMLDocumentParser* parser) override
+ void call(XMLDocumentParser* parser) override
{
parser->internalSubset(m_name, m_externalID, m_systemID);
}
@@ -281,12 +281,12 @@ public:
{
}
- virtual ~PendingErrorCallback()
+ ~PendingErrorCallback() override
{
xmlFree(m_message);
}
- virtual void call(XMLDocumentParser* parser) override
+ void call(XMLDocumentParser* parser) override
{
parser->handleError(m_type, reinterpret_cast<char*>(m_message), TextPosition(m_lineNumber, m_columnNumber));
}
« no previous file with comments | « Source/core/xml/parser/XMLDocumentParser.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698