Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1914)

Unified Diff: Source/core/xml/XPathPredicate.h

Issue 1224823006: Fix virtual/override/final usage in Source/core/xml/. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/xml/XPathPath.h ('k') | Source/core/xml/XPathStep.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/xml/XPathPredicate.h
diff --git a/Source/core/xml/XPathPredicate.h b/Source/core/xml/XPathPredicate.h
index d34752f27b0d2f396cb16a1795947a9a4cda788d..383ef69f8db890206306839feaa6d61b41f203bc 100644
--- a/Source/core/xml/XPathPredicate.h
+++ b/Source/core/xml/XPathPredicate.h
@@ -40,8 +40,8 @@ public:
DECLARE_VIRTUAL_TRACE();
private:
- virtual Value evaluate(EvaluationContext&) const override;
- virtual Value::Type resultType() const override { return Value::NumberValue; }
+ Value evaluate(EvaluationContext&) const override;
+ Value::Type resultType() const override { return Value::NumberValue; }
Value m_value;
};
@@ -52,16 +52,16 @@ public:
DECLARE_VIRTUAL_TRACE();
private:
- virtual Value evaluate(EvaluationContext&) const override;
- virtual Value::Type resultType() const override { return Value::StringValue; }
+ Value evaluate(EvaluationContext&) const override;
+ Value::Type resultType() const override { return Value::StringValue; }
Value m_value;
};
class Negative final : public Expression {
private:
- virtual Value evaluate(EvaluationContext&) const override;
- virtual Value::Type resultType() const override { return Value::NumberValue; }
+ Value evaluate(EvaluationContext&) const override;
+ Value::Type resultType() const override { return Value::NumberValue; }
};
class NumericOp final : public Expression {
@@ -72,8 +72,8 @@ public:
NumericOp(Opcode, Expression* lhs, Expression* rhs);
private:
- virtual Value evaluate(EvaluationContext&) const override;
- virtual Value::Type resultType() const override { return Value::NumberValue; }
+ Value evaluate(EvaluationContext&) const override;
+ Value::Type resultType() const override { return Value::NumberValue; }
Opcode m_opcode;
};
@@ -82,10 +82,10 @@ class EqTestOp final : public Expression {
public:
enum Opcode { OpcodeEqual, OpcodeNotEqual, OpcodeGreaterThan, OpcodeLessThan, OpcodeGreaterOrEqual, OpcodeLessOrEqual };
EqTestOp(Opcode, Expression* lhs, Expression* rhs);
- virtual Value evaluate(EvaluationContext&) const override;
+ Value evaluate(EvaluationContext&) const override;
private:
- virtual Value::Type resultType() const override { return Value::BooleanValue; }
+ Value::Type resultType() const override { return Value::BooleanValue; }
bool compare(EvaluationContext&, const Value&, const Value&) const;
Opcode m_opcode;
@@ -97,17 +97,17 @@ public:
LogicalOp(Opcode, Expression* lhs, Expression* rhs);
private:
- virtual Value::Type resultType() const override { return Value::BooleanValue; }
+ Value::Type resultType() const override { return Value::BooleanValue; }
bool shortCircuitOn() const;
- virtual Value evaluate(EvaluationContext&) const override;
+ Value evaluate(EvaluationContext&) const override;
Opcode m_opcode;
};
class Union final : public Expression {
private:
- virtual Value evaluate(EvaluationContext&) const override;
- virtual Value::Type resultType() const override { return Value::NodeSetValue; }
+ Value evaluate(EvaluationContext&) const override;
+ Value::Type resultType() const override { return Value::NodeSetValue; }
};
class Predicate final : public GarbageCollected<Predicate> {
« no previous file with comments | « Source/core/xml/XPathPath.h ('k') | Source/core/xml/XPathStep.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698