Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(170)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1224823006: Fix virtual/override/final usage in Source/core/xml/. (Closed)

Created:
5 years, 5 months ago by tkent
Modified:
5 years, 5 months ago
Reviewers:
yosin_UTC9
CC:
blink-reviews, blink-reviews-style_chromium.org
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Fix virtual/override/final usage in Source/core/xml/. - We should specify just one of them to a function. - Non-base virtual destructors should have |override| keywords. This CL has no behavior changes. BUG=417463 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=198377

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+119 lines, -119 lines) Patch
M Source/core/xml/DocumentXSLT.cpp View 2 chunks +4 lines, -4 lines 0 comments Download
M Source/core/xml/NativeXPathNSResolver.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/xml/XPathExpressionNode.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/xml/XPathFunctions.cpp View 1 chunk +54 lines, -54 lines 0 comments Download
M Source/core/xml/XPathPath.h View 3 chunks +9 lines, -9 lines 0 comments Download
M Source/core/xml/XPathPredicate.h View 5 chunks +14 lines, -14 lines 0 comments Download
M Source/core/xml/XPathStep.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/xml/XPathVariableReference.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/xml/XSLStyleSheet.h View 3 chunks +11 lines, -11 lines 0 comments Download
M Source/core/xml/parser/XMLDocumentParser.h View 3 chunks +11 lines, -11 lines 0 comments Download
M Source/core/xml/parser/XMLDocumentParser.cpp View 9 chunks +11 lines, -11 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
tkent
yosin@, would you review this please?
5 years, 5 months ago (2015-07-07 07:42:43 UTC) #2
yosin_UTC9
lgtm
5 years, 5 months ago (2015-07-07 08:27:53 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1224823006/1
5 years, 5 months ago (2015-07-07 08:28:06 UTC) #5
commit-bot: I haz the power
5 years, 5 months ago (2015-07-07 08:33:07 UTC) #6
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=198377

Powered by Google App Engine
This is Rietveld 408576698