Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(818)

Issue 12248014: MIPS: Add android build support for mips in gyp. (Closed)

Created:
7 years, 10 months ago by Paul Lind
Modified:
7 years, 10 months ago
CC:
v8-dev
Base URL:
git://github.com/v8/v8.git@gbleed
Visibility:
Public.

Description

MIPS: Add android build support for mips in gyp. Added mipsel target in gyp and makefiles used for android build. BUG= Committed: http://code.google.com/p/v8/source/detail?r=13723

Patch Set 1 #

Total comments: 2

Patch Set 2 : Remove duplication with common.gypi, per code review. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -6 lines) Patch
M Makefile View 1 chunk +1 line, -1 line 0 comments Download
M Makefile.android View 2 chunks +11 lines, -5 lines 0 comments Download
M build/android.gypi View 1 2 chunks +15 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Paul Lind
PTAL...
7 years, 10 months ago (2013-02-12 04:13:45 UTC) #1
Jakob Kummerow
Generally LGTM, but I do have a question (see below). I guess one of the ...
7 years, 10 months ago (2013-02-12 11:59:39 UTC) #2
Paul Lind
Fixed per your review, and rebased on r13717. Note that mips build is currently busted, ...
7 years, 10 months ago (2013-02-25 16:23:22 UTC) #3
Jakob Kummerow
LGTM, landing.
7 years, 10 months ago (2013-02-25 16:32:30 UTC) #4
Jakob Kummerow
7 years, 10 months ago (2013-02-25 16:39:13 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 manually as r13723 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698