Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(189)

Issue 12248013: Revert 181828, CL introducing leaks was reverted in 181831. (Closed)

Created:
7 years, 10 months ago by msw
Modified:
7 years, 10 months ago
Reviewers:
msw - DO NOT USE
CC:
chromium-reviews, glider+watch_chromium.org, timurrrr+watch_chromium.org, bruening+watch_chromium.org
Visibility:
Public.

Description

Revert 181828, CL introducing leaks was reverted in 181831. > Suppress TabbedPaneTest and FocusManagerTest leaks. > > My http://crrev.com/181798 introduced Valgrind leaks: > http://build.chromium.org/p/chromium.memory.fyi/builders/Chromium%20OS%20%28valgrind%29%283%29/builds/22339 > I'll suppress the leaks temporarily while I'm fixing them. > > BUG=138059, 175644 > TEST=No Valgrind leaks reported from these tests. > TBR=zhaoqin@chromium.org > > Review URL: https://codereview.chromium.org/12226104 TBR=msw@google.com Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=181832

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -19 lines) Patch
M tools/valgrind/memcheck/suppressions.txt View 1 chunk +0 lines, -19 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
msw
7 years, 10 months ago (2013-02-12 02:48:03 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698