Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(215)

Issue 12248012: Makes a gap at the top boundary of message center. (Closed)

Created:
7 years, 10 months ago by Jun Mukai
Modified:
7 years, 10 months ago
Reviewers:
stevenjb
CC:
chromium-reviews, sadrul, ben+watch_chromium.org
Visibility:
Public.

Description

Makes a gap at the top boundary of message center. BUG=174097 TEST=manually checked on goobuntu Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=182307

Patch Set 1 #

Total comments: 2

Patch Set 2 : std::max #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -14 lines) Patch
M ash/system/status_area_widget_delegate.cc View 2 chunks +1 line, -6 lines 0 comments Download
M ash/system/tray/tray_constants.h View 1 chunk +2 lines, -0 lines 0 comments Download
M ash/system/tray/tray_constants.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M ash/system/web_notification/web_notification_tray.cc View 1 2 chunks +25 lines, -8 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Jun Mukai
7 years, 10 months ago (2013-02-12 02:47:02 UTC) #1
stevenjb
https://codereview.chromium.org/12248012/diff/1/ash/system/web_notification/web_notification_tray.cc File ash/system/web_notification/web_notification_tray.cc (right): https://codereview.chromium.org/12248012/diff/1/ash/system/web_notification/web_notification_tray.cc#newcode148 ash/system/web_notification/web_notification_tray.cc:148: max_height -= kTraySpacing; We should just subtract kTraySpacing when ...
7 years, 10 months ago (2013-02-13 18:54:45 UTC) #2
Jun Mukai
https://codereview.chromium.org/12248012/diff/1/ash/system/web_notification/web_notification_tray.cc File ash/system/web_notification/web_notification_tray.cc (right): https://codereview.chromium.org/12248012/diff/1/ash/system/web_notification/web_notification_tray.cc#newcode148 ash/system/web_notification/web_notification_tray.cc:148: max_height -= kTraySpacing; On 2013/02/13 18:54:45, stevenjb (chromium) wrote: ...
7 years, 10 months ago (2013-02-13 19:42:27 UTC) #3
stevenjb
lgtm
7 years, 10 months ago (2013-02-13 19:44:25 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mukai@chromium.org/12248012/4001
7 years, 10 months ago (2013-02-13 19:46:41 UTC) #5
commit-bot: I haz the power
7 years, 10 months ago (2013-02-13 21:11:09 UTC) #6
Retried try job too often on win_rel for step(s) browser_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...

Powered by Google App Engine
This is Rietveld 408576698