visual_studio/NativeClientVSAddIn/NaCl.Build.CPPTasks/NaClCompile.cs - Issue 12248006: [VS Addin] Fix parallel building.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: visual_studio/NativeClientVSAddIn/NaCl.Build.CPPTasks/NaClCompile.cs

Issue 12248006: [VS Addin] Fix parallel building. (Closed) Base URL: http://nativeclient-sdk.googlecode.com/svn/trunk/src

Patch Set: Created 7 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | visual_studio/NativeClientVSAddIn/TestingProjects/BlankValidSolution/NaClProject/multiprocess.props » ('j') | visual_studio/NativeClientVSAddIn/UnitTests/BaseCompileTest.cs » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: visual_studio/NativeClientVSAddIn/NaCl.Build.CPPTasks/NaClCompile.cs

diff --git a/visual_studio/NativeClientVSAddIn/NaCl.Build.CPPTasks/NaClCompile.cs b/visual_studio/NativeClientVSAddIn/NaCl.Build.CPPTasks/NaClCompile.cs

index 2b6bf403019d2d46afda1b6891c14a51bc6443e4..30600d460552ca92a8f2325eaa06aa499548904e 100644

--- a/visual_studio/NativeClientVSAddIn/NaCl.Build.CPPTasks/NaClCompile.cs

+++ b/visual_studio/NativeClientVSAddIn/NaCl.Build.CPPTasks/NaClCompile.cs

@@ -373,11 +373,12 @@ namespace NaCl.Build.CPPTasks

foreach (KeyValuePair<string, List<ITaskItem>> entry in srcGroups)

{

string commandLine = entry.Key;

- string cmd = "\"" + pathToTool + "\" " + commandLine + "--";

+ string cmd = "\"" + pathToTool + "\" " + commandLine + " --";

List<ITaskItem> sources = entry.Value;

foreach (ITaskItem sourceItem in sources)

{

+ cmd += " ";

cmd += GCCUtilities.ConvertPathWindowsToPosix(sourceItem.ToString());

}