Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(81)

Side by Side Diff: test/unittests/compiler/js-typed-lowering-unittest.cc

Issue 1224793002: Loads and stores to global vars are now made via property cell shortcuts installed into parent scri… (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Addressing comments Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « test/unittests/compiler/js-type-feedback-unittest.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 the V8 project authors. All rights reserved. 1 // Copyright 2014 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/code-factory.h" 5 #include "src/code-factory.h"
6 #include "src/compiler/access-builder.h" 6 #include "src/compiler/access-builder.h"
7 #include "src/compiler/js-graph.h" 7 #include "src/compiler/js-graph.h"
8 #include "src/compiler/js-operator.h" 8 #include "src/compiler/js-operator.h"
9 #include "src/compiler/js-typed-lowering.h" 9 #include "src/compiler/js-typed-lowering.h"
10 #include "src/compiler/machine-operator.h" 10 #include "src/compiler/machine-operator.h"
(...skipping 879 matching lines...) Expand 10 before | Expand all | Expand 10 after
890 VectorSlotPair feedback; 890 VectorSlotPair feedback;
891 Node* global = UndefinedConstant(); 891 Node* global = UndefinedConstant();
892 Node* vector = UndefinedConstant(); 892 Node* vector = UndefinedConstant();
893 Node* context = UndefinedConstant(); 893 Node* context = UndefinedConstant();
894 Node* effect = graph()->start(); 894 Node* effect = graph()->start();
895 Node* control = graph()->start(); 895 Node* control = graph()->start();
896 896
897 for (size_t i = 0; i < arraysize(names); i++) { 897 for (size_t i = 0; i < arraysize(names); i++) {
898 Unique<Name> name = Unique<Name>::CreateImmovable(names[i]); 898 Unique<Name> name = Unique<Name>::CreateImmovable(names[i]);
899 Reduction r = Reduce(graph()->NewNode( 899 Reduction r = Reduce(graph()->NewNode(
900 javascript()->LoadGlobal(name, feedback), global, vector, context, 900 javascript()->LoadGlobal(name, feedback), context, global, vector,
901 EmptyFrameState(), EmptyFrameState(), effect, control)); 901 context, EmptyFrameState(), EmptyFrameState(), effect, control));
902 902
903 ASSERT_TRUE(r.Changed()); 903 ASSERT_TRUE(r.Changed());
904 EXPECT_THAT(r.replacement(), matches[i]); 904 EXPECT_THAT(r.replacement(), matches[i]);
905 } 905 }
906 } 906 }
907 907
908 908
909 // ----------------------------------------------------------------------------- 909 // -----------------------------------------------------------------------------
910 // JSLoadDynamicGlobal 910 // JSLoadDynamicGlobal
911 911
(...skipping 184 matching lines...) Expand 10 before | Expand all | Expand 10 after
1096 EXPECT_THAT(r.replacement(), 1096 EXPECT_THAT(r.replacement(),
1097 IsFinish(IsAllocate(IsNumberConstant(Context::SizeFor( 1097 IsFinish(IsAllocate(IsNumberConstant(Context::SizeFor(
1098 Context::MIN_CONTEXT_SLOTS)), 1098 Context::MIN_CONTEXT_SLOTS)),
1099 effect, control), 1099 effect, control),
1100 _)); 1100 _));
1101 } 1101 }
1102 1102
1103 } // namespace compiler 1103 } // namespace compiler
1104 } // namespace internal 1104 } // namespace internal
1105 } // namespace v8 1105 } // namespace v8
OLDNEW
« no previous file with comments | « test/unittests/compiler/js-type-feedback-unittest.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698