Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(184)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1224783002: add matrix options to drawDrawable (Closed)

Created:
5 years, 5 months ago by reed1
Modified:
5 years, 5 months ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

add matrix options to drawDrawable BUG=skia: Committed: https://skia.googlesource.com/skia/+/a8db72864a43ad1fbba3c2892cf5cd88060a43ef

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Patch Set 5 : modify gm #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+67 lines, -24 lines) Patch
M gm/drawable.cpp View 1 2 3 4 2 chunks +17 lines, -6 lines 0 comments Download
M include/core/SkCanvas.h View 1 2 chunks +3 lines, -2 lines 0 comments Download
M include/core/SkDrawable.h View 1 1 chunk +2 lines, -1 line 0 comments Download
M src/core/SkCanvas.cpp View 1 1 chunk +26 lines, -5 lines 0 comments Download
M src/core/SkDrawable.cpp View 1 2 2 chunks +9 lines, -1 line 0 comments Download
M src/core/SkRecordDraw.cpp View 1 1 chunk +2 lines, -2 lines 0 comments Download
M src/core/SkRecorder.h View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M src/core/SkRecorder.cpp View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
M src/core/SkRecords.h View 1 2 chunks +2 lines, -1 line 1 comment Download
M src/utils/android/SkAndroidSDKCanvas.h View 1 1 chunk +1 line, -1 line 0 comments Download
M src/utils/android/SkAndroidSDKCanvas.cpp View 1 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 23 (11 generated)
reed1
Is this the sort of API extension you had in mind?
5 years, 5 months ago (2015-07-06 17:17:04 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1224783002/20001
5 years, 5 months ago (2015-07-07 14:11:29 UTC) #4
reed1
ptal
5 years, 5 months ago (2015-07-07 15:29:36 UTC) #7
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1224783002/40001
5 years, 5 months ago (2015-07-07 15:29:55 UTC) #9
abarth-chromium
LGTM
5 years, 5 months ago (2015-07-07 16:05:02 UTC) #11
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1224783002/80001
5 years, 5 months ago (2015-07-07 16:59:17 UTC) #14
robertphillips
lgtm. Does this break the debugger?
5 years, 5 months ago (2015-07-07 17:01:05 UTC) #17
mtklein
lgtm
5 years, 5 months ago (2015-07-07 17:05:12 UTC) #18
mtklein
https://codereview.chromium.org/1224783002/diff/80001/src/core/SkRecords.h File src/core/SkRecords.h (right): https://codereview.chromium.org/1224783002/diff/80001/src/core/SkRecords.h#newcode293 src/core/SkRecords.h:293: RECORD3(DrawDrawable, Optional<SkMatrix>, matrix, SkRect, worstCaseBounds, int32_t, index); Ooh, actually, ...
5 years, 5 months ago (2015-07-07 17:07:06 UTC) #19
mtklein
On 2015/07/07 17:07:06, mtklein wrote: > https://codereview.chromium.org/1224783002/diff/80001/src/core/SkRecords.h > File src/core/SkRecords.h (right): > > https://codereview.chromium.org/1224783002/diff/80001/src/core/SkRecords.h#newcode293 > ...
5 years, 5 months ago (2015-07-07 17:19:48 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1224783002/80001
5 years, 5 months ago (2015-07-07 17:21:53 UTC) #22
commit-bot: I haz the power
5 years, 5 months ago (2015-07-07 17:22:36 UTC) #23
Message was sent while issue was closed. 
Committed patchset #5 (id:80001) as
https://skia.googlesource.com/skia/+/a8db72864a43ad1fbba3c2892cf5cd88060a43ef

Powered by Google App Engine
This is Rietveld 408576698