Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(264)

Issue 1224773003: Adds ActionSequence to sprites and improved explosions in game demo (Closed)

Created:
5 years, 5 months ago by viktorl
Modified:
5 years, 5 months ago
CC:
abarth-chromium, gregsimon, jackson_old, mojo-reviews_chromium.org, qsr+mojo_chromium.org
Base URL:
git@github.com:domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Adds ActionSequence to sprites and improved explosions in game demo. Adds ActionRemoveFromParent Adds ActionCallFunction R=abarth@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/125c06778aab6e990710ccdcb675e3622dada0d3

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+222 lines, -48 lines) Patch
M sky/sdk/example/game/lib/action.dart View 3 chunks +84 lines, -5 lines 0 comments Download
M sky/sdk/example/game/lib/game_demo_world.dart View 7 chunks +52 lines, -11 lines 0 comments Download
M sky/sdk/example/game/res/sprites.json View 16 chunks +86 lines, -32 lines 0 comments Download
M sky/sdk/example/game/res/sprites.png View Binary file 0 comments Download

Messages

Total messages: 5 (2 generated)
viktorl
5 years, 5 months ago (2015-07-06 15:48:20 UTC) #2
abarth-chromium
lgtm
5 years, 5 months ago (2015-07-06 16:05:35 UTC) #4
viktorl
5 years, 5 months ago (2015-07-07 07:40:01 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
125c06778aab6e990710ccdcb675e3622dada0d3 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698