Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(333)

Unified Diff: chrome/browser/devtools/device/tcp_device_provider.h

Issue 1224743002: DevTools: allow to pass list of remote debugging targets as command line argument (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Renamed SelfAsDeviceProvider to TCPDeviceProvider Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/devtools/device/tcp_device_provider.h
diff --git a/chrome/browser/devtools/device/self_device_provider.h b/chrome/browser/devtools/device/tcp_device_provider.h
similarity index 60%
rename from chrome/browser/devtools/device/self_device_provider.h
rename to chrome/browser/devtools/device/tcp_device_provider.h
index 4200dc3b3965f4d0047525c596af4a155f6b1b56..fe8c8cc3983d8f017d4a453702979788faa57379 100644
--- a/chrome/browser/devtools/device/self_device_provider.h
+++ b/chrome/browser/devtools/device/tcp_device_provider.h
@@ -2,15 +2,21 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
-#ifndef CHROME_BROWSER_DEVTOOLS_DEVICE_SELF_DEVICE_PROVIDER_H_
-#define CHROME_BROWSER_DEVTOOLS_DEVICE_SELF_DEVICE_PROVIDER_H_
+#ifndef CHROME_BROWSER_DEVTOOLS_DEVICE_TCP_DEVICE_PROVIDER_H_
+#define CHROME_BROWSER_DEVTOOLS_DEVICE_TCP_DEVICE_PROVIDER_H_
+
+#include <set>
#include "chrome/browser/devtools/device/android_device_manager.h"
+#include "net/base/host_port_pair.h"
// Instantiate this class only in a test and/or when DEBUG_DEVTOOLS is defined.
-class SelfAsDeviceProvider : public AndroidDeviceManager::DeviceProvider {
+class TCPDeviceProvider : public AndroidDeviceManager::DeviceProvider {
public:
- explicit SelfAsDeviceProvider(int port);
+ static scoped_refptr<TCPDeviceProvider> CreateForLocalhost(uint16_t port);
+
+ using HostPortSet = std::set<net::HostPortPair>;
+ explicit TCPDeviceProvider(const HostPortSet& targets);
void QueryDevices(const SerialsCallback& callback) override;
@@ -26,10 +32,10 @@ class SelfAsDeviceProvider : public AndroidDeviceManager::DeviceProvider {
void set_release_callback_for_test(const base::Closure& callback);
private:
- ~SelfAsDeviceProvider() override;
+ ~TCPDeviceProvider() override;
- int port_;
+ HostPortSet targets_;
base::Closure release_callback_;
};
-#endif // CHROME_BROWSER_DEVTOOLS_DEVICE_SELF_DEVICE_PROVIDER_H_
+#endif // CHROME_BROWSER_DEVTOOLS_DEVICE_TCP_DEVICE_PROVIDER_H_

Powered by Google App Engine
This is Rietveld 408576698