Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1576)

Issue 1224643004: Index -> Entry and Key -> Index in elements.[cc|h] (Closed)

Created:
5 years, 5 months ago by Toon Verwaest
Modified:
5 years, 5 months ago
Reviewers:
Igor Sheludko
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Index -> Entry and Key -> Index in elements.[cc|h] BUG=v8:4137 LOG=n Committed: https://crrev.com/ca7feba733a57d41a61680cc69ab277b93131168 Cr-Commit-Position: refs/heads/master@{#29514}

Patch Set 1 #

Patch Set 2 : #

Total comments: 3

Patch Set 3 : Addressed comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+231 lines, -237 lines) Patch
M src/elements.h View 1 2 5 chunks +30 lines, -37 lines 0 comments Download
M src/elements.cc View 1 2 31 chunks +199 lines, -199 lines 0 comments Download
M src/lookup-inl.h View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 9 (3 generated)
Toon Verwaest
ptal
5 years, 5 months ago (2015-07-07 10:02:59 UTC) #2
Igor Sheludko
lgtm with nits: https://codereview.chromium.org/1224643004/diff/20001/src/elements.cc File src/elements.cc (right): https://codereview.chromium.org/1224643004/diff/20001/src/elements.cc#newcode890 src/elements.cc:890: for (int i = 0; i ...
5 years, 5 months ago (2015-07-07 11:01:42 UTC) #3
Toon Verwaest
Addressed comments, thanks. Landing.
5 years, 5 months ago (2015-07-07 11:28:09 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1224643004/40001
5 years, 5 months ago (2015-07-07 11:28:34 UTC) #7
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 5 months ago (2015-07-07 11:52:54 UTC) #8
commit-bot: I haz the power
5 years, 5 months ago (2015-07-07 11:53:14 UTC) #9
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/ca7feba733a57d41a61680cc69ab277b93131168
Cr-Commit-Position: refs/heads/master@{#29514}

Powered by Google App Engine
This is Rietveld 408576698