Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(633)

Unified Diff: src/hydrogen.h

Issue 122463004: Revert "Fix compilation with C++11." and "Allocation site support for monomorphic StringAdds in Bin… (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 6 years, 12 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/code-stubs-hydrogen.cc ('k') | src/hydrogen.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/hydrogen.h
diff --git a/src/hydrogen.h b/src/hydrogen.h
index ca3fb4349b67a180218a856faa1cc81cb5a411ee..ea4da9abf1c75870cdd7c5060b869b9b882b19b9 100644
--- a/src/hydrogen.h
+++ b/src/hydrogen.h
@@ -995,35 +995,6 @@ class HIfContinuation V8_FINAL {
};
-class HAllocationMode V8_FINAL BASE_EMBEDDED {
- public:
- explicit HAllocationMode(Handle<AllocationSite> feedback_site)
- : current_site_(NULL), feedback_site_(feedback_site),
- pretenure_flag_(NOT_TENURED) {}
- explicit HAllocationMode(HValue* current_site)
- : current_site_(current_site), pretenure_flag_(NOT_TENURED) {}
- explicit HAllocationMode(PretenureFlag pretenure_flag)
- : current_site_(NULL), pretenure_flag_(pretenure_flag) {}
-
- HValue* current_site() const { return current_site_; }
- Handle<AllocationSite> feedback_site() const { return feedback_site_; }
-
- bool CreateAllocationMementos() const V8_WARN_UNUSED_RESULT {
- return current_site() != NULL;
- }
-
- PretenureFlag GetPretenureMode() const V8_WARN_UNUSED_RESULT {
- if (!feedback_site().is_null()) return feedback_site()->GetPretenureMode();
- return pretenure_flag_;
- }
-
- private:
- HValue* current_site_;
- Handle<AllocationSite> feedback_site_;
- PretenureFlag pretenure_flag_;
-};
-
-
class HGraphBuilder {
public:
explicit HGraphBuilder(CompilationInfo* info)
@@ -1320,18 +1291,9 @@ class HGraphBuilder {
HValue* BuildUncheckedDictionaryElementLoad(HValue* receiver,
HValue* key);
- // Allocates a new object according with the given allocation properties.
- HAllocate* BuildAllocate(HValue* object_size,
- HType type,
- InstanceType instance_type,
- HAllocationMode allocation_mode);
- // Computes the sum of two string lengths, taking care of overflow handling.
- HValue* BuildAddStringLengths(HValue* left_length, HValue* right_length);
- // Creates a cons string using the two input strings.
- HValue* BuildCreateConsString(HValue* length,
- HValue* left,
- HValue* right,
- HAllocationMode allocation_mode);
+ // Computes the size for a sequential string of the given length and encoding.
+ HValue* BuildSeqStringSizeFor(HValue* length,
+ String::Encoding encoding);
// Copies characters from one sequential string to another.
void BuildCopySeqStringChars(HValue* src,
HValue* src_offset,
@@ -1343,11 +1305,11 @@ class HGraphBuilder {
// Both operands are non-empty strings.
HValue* BuildUncheckedStringAdd(HValue* left,
HValue* right,
- HAllocationMode allocation_mode);
- // Add two strings using allocation mode, validating type feedback.
+ PretenureFlag pretenure_flag);
+ // Both operands are strings.
HValue* BuildStringAdd(HValue* left,
HValue* right,
- HAllocationMode allocation_mode);
+ PretenureFlag pretenure_flag);
HInstruction* BuildUncheckedMonomorphicElementAccess(
HValue* checked_object,
@@ -1370,14 +1332,7 @@ class HGraphBuilder {
HLoadNamedField* BuildLoadNamedField(HValue* object, HObjectAccess access);
HInstruction* AddLoadNamedField(HValue* object, HObjectAccess access);
- HInstruction* AddLoadStringInstanceType(HValue* string);
- HInstruction* AddLoadStringLength(HValue* string);
- HStoreNamedField* AddStoreMapNoWriteBarrier(HValue* object, HValue* map) {
- HStoreNamedField* store_map = Add<HStoreNamedField>(
- object, HObjectAccess::ForMap(), map);
- store_map->SkipWriteBarrier();
- return store_map;
- }
+ HInstruction* BuildLoadStringLength(HValue* object, HValue* checked_value);
HStoreNamedField* AddStoreMapConstant(HValue* object, Handle<Map> map);
HStoreNamedField* AddStoreMapConstantNoWriteBarrier(HValue* object,
Handle<Map> map) {
@@ -1398,8 +1353,7 @@ class HGraphBuilder {
Handle<Type> left_type,
Handle<Type> right_type,
Handle<Type> result_type,
- Maybe<int> fixed_right_arg,
- HAllocationMode allocation_mode);
+ Maybe<int> fixed_right_arg);
HLoadNamedField* AddLoadFixedArrayLength(HValue *object);
« no previous file with comments | « src/code-stubs-hydrogen.cc ('k') | src/hydrogen.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698