Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(341)

Issue 122463004: Revert "Fix compilation with C++11." and "Allocation site support for monomorphic StringAdds in Bin… (Closed)

Created:
6 years, 11 months ago by Benedikt Meurer
Modified:
6 years, 11 months ago
Reviewers:
ulan
CC:
v8-dev
Visibility:
Public.

Description

Revert "Fix compilation with C++11." and "Allocation site support for monomorphic StringAdds in BinaryOps.". This reverts commit r18431 and r18432 for breaking the Linux nosnapshot build. R=ulan@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=18434

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+305 lines, -845 lines) Patch
M src/arm/code-stubs-arm.cc View 4 chunks +12 lines, -56 lines 0 comments Download
M src/ast.h View 2 chunks +0 lines, -5 lines 0 comments Download
M src/code-stubs.h View 6 chunks +8 lines, -93 lines 0 comments Download
M src/code-stubs.cc View 1 chunk +0 lines, -22 lines 0 comments Download
M src/code-stubs-hydrogen.cc View 6 chunks +6 lines, -34 lines 0 comments Download
M src/hydrogen.h View 5 chunks +8 lines, -54 lines 0 comments Download
M src/hydrogen.cc View 13 chunks +224 lines, -321 lines 0 comments Download
M src/hydrogen-instructions.h View 1 chunk +20 lines, -30 lines 0 comments Download
M src/hydrogen-instructions.cc View 2 chunks +2 lines, -20 lines 0 comments Download
M src/ia32/code-stubs-ia32.cc View 3 chunks +0 lines, -42 lines 0 comments Download
M src/ia32/lithium-codegen-ia32.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/ic.h View 3 chunks +2 lines, -21 lines 0 comments Download
M src/ic.cc View 7 chunks +6 lines, -64 lines 0 comments Download
M src/objects.h View 2 chunks +2 lines, -6 lines 0 comments Download
M src/objects.cc View 1 chunk +0 lines, -6 lines 0 comments Download
M src/objects-inl.h View 1 chunk +1 line, -3 lines 0 comments Download
M src/type-info.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/type-info.cc View 3 chunks +0 lines, -9 lines 0 comments Download
M src/typing.cc View 1 chunk +1 line, -4 lines 0 comments Download
M src/x64/code-stubs-x64.cc View 4 chunks +12 lines, -53 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Benedikt Meurer
PTAL
6 years, 11 months ago (2014-01-02 10:28:55 UTC) #1
ulan
lgtm
6 years, 11 months ago (2014-01-02 10:35:23 UTC) #2
Benedikt Meurer
6 years, 11 months ago (2014-01-02 10:39:00 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r18434 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698