Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(358)

Issue 1224623017: [x64] Fix handling of Smi constants in LSubI and LBitI (Closed)

Created:
5 years, 5 months ago by Jakob Kummerow
Modified:
5 years, 5 months ago
Reviewers:
Toon Verwaest
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[x64] Fix handling of Smi constants in LSubI and LBitI Smi immediates are not supported, so instructions with Smi representations need their constants in a register. LAddI has already been doing this. The manifestation of the bug was that an operation would compute 0 instead of the correct result. BUG=chromium:478612 LOG=y R=verwaest@chromium.org Committed: https://crrev.com/5379d8bc36b3388df4f5a6f7e0a86168f1a5ff0e Cr-Commit-Position: refs/heads/master@{#29529}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+66 lines, -2 lines) Patch
M src/x64/lithium-x64.cc View 2 chunks +14 lines, -2 lines 0 comments Download
A test/mjsunit/regress/regress-crbug-478612.js View 1 chunk +52 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
Jakob Kummerow
PTAL.
5 years, 5 months ago (2015-07-07 13:02:49 UTC) #1
Toon Verwaest
lgtm, thanks for fixing!
5 years, 5 months ago (2015-07-08 09:56:24 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1224623017/1
5 years, 5 months ago (2015-07-08 09:57:16 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 5 months ago (2015-07-08 10:20:29 UTC) #5
commit-bot: I haz the power
5 years, 5 months ago (2015-07-08 10:20:41 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/5379d8bc36b3388df4f5a6f7e0a86168f1a5ff0e
Cr-Commit-Position: refs/heads/master@{#29529}

Powered by Google App Engine
This is Rietveld 408576698