Refactor ParseArrayGeometry to use standard Chromium facilities.

content/renderer/media/media_stream_audio_processor_options.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/renderer/media/media_stream_audio_processor_options.h"
 
 #include "base/files/file_path.h"
 #include "base/files/file_util.h"
 #include "base/logging.h"
 #include "base/metrics/field_trial.h"
 #include "base/metrics/histogram.h"
 #include "base/strings/string_number_conversions.h"
+#include "base/strings/string_split.h"
+#include "base/strings/string_util.h"
 #include "base/strings/utf_string_conversions.h"
 #include "content/common/media/media_stream_options.h"
 #include "content/renderer/media/media_stream_constraints_util.h"
 #include "content/renderer/media/media_stream_source.h"
 #include "content/renderer/media/rtc_media_constraints.h"
 #include "media/audio/audio_parameters.h"
 #include "third_party/webrtc/modules/audio_processing/include/audio_processing.h"
 #include "third_party/webrtc/modules/audio_processing/typing_detection.h"
 
 namespace content {
@@ skipping 359 matching lines @@
 
   int median = 0, std = 0;
   float dummy = 0;
   if (echo_cancellation->GetDelayMetrics(&median, &std, &dummy) ==
       webrtc::AudioProcessing::kNoError) {
     stats->echo_delay_median_ms = median;
     stats->echo_delay_std_ms = std;
   }
 }
 
+std::vector<webrtc::Point> ParseArrayGeometry(
+    const std::string& geometry_string) {
+  const auto tokens =
+      base::SplitString(geometry_string, base::kWhitespaceASCII,
+                        base::KEEP_WHITESPACE, base::SPLIT_WANT_NONEMPTY);

[emircan, 2015/08/03 18:06:23]

const auto& tokens?

[ajm, 2015/08/04 01:16:35]

Same comment here. FWIW a bunch of anecdotal callsites to SplitString() I
surveyed don't assign to a reference.

+  std::vector<webrtc::Point> geometry;
+  if (tokens.size() < 3 || tokens.size() % 3 != 0) {
+    LOG(ERROR) << "Malformed geometry string: " << geometry_string;
+    return geometry;
+  }
+
+  std::vector<float> float_tokens;
+  float_tokens.reserve(tokens.size());
+  for (const auto& token : tokens) {
+    double float_token;
+    if (!base::StringToDouble(token, &float_token)) {
+      LOG(ERROR) << "Unable to convert token=" << token
+                 << " to double from geometry string: " << geometry_string;
+      return geometry;
+    }
+    float_tokens.push_back(float_token);
+  }
+
+  geometry.reserve(float_tokens.size() / 3);
+  for (size_t i = 0; i < float_tokens.size(); i += 3) {
+    geometry.push_back(webrtc::Point(float_tokens[i + 0], float_tokens[i + 1],
+                                     float_tokens[i + 2]));
+  }
+
+  return geometry;
+}
+
 }  // namespace content