chrome/browser/resources/md_downloads/item_view.html - Issue 1224623013: Port downloads.ItemView to a Polymer component.

Side by Side Diff: chrome/browser/resources/md_downloads/item_view.html

Issue 1224623013: Port downloads.ItemView to a Polymer component. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@p-dl-rough-draft2

Patch Set: actually remove i18n changes Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « chrome/browser/resources/md_downloads/downloads.html ('k') | chrome/browser/resources/md_downloads/item_view.js » ('j') | chrome/browser/resources/md_downloads/item_view.js » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <link rel="import" href="chrome://resources/html/cr.html">
	michaelpg 2015/07/08 19:39:52 nit: include polymer nit: include polymer Dan Beam 2015/07/09 18:13:45 Done. Show quoted text On 2015/07/08 19:39:52, michaelpg wrote: > nit: include polymer Done.
	2

	3 <dom-module id="item-view">

	4 <template>

	5 <div id="date-container">

	6 <div id="since"></div>

	7 <div id="date"></div>

	8 </div>

	9

	10 <div id="safe">

	11 <div id="progress"></div>

	12 <img id="safe-icon" alt="">

	13 <div id="title-area">

	14 <a is="action-link" id="file-link" column-type="name"></a>
	michaelpg 2015/07/08 19:39:52 Not 100% clear on how focusing works, but could th Not 100% clear on how focusing works, but could the element manage its own focus state? Dan Beam 2015/07/09 18:13:45 it's possible this component could have it's own c Show quoted text On 2015/07/08 19:39:52, michaelpg wrote: > Not 100% clear on how focusing works, but could the element manage its own focus > state? it's possible this component could have it's own cr.ui.FocusRow, but I haven't really thought about any of that yet (I'm going to add it back soon). I can remove column-type if you'd like, but I didn't see a huge issue with leaving them for now. michaelpg 2015/07/10 00:56:26 Acknowledged. Show quoted text On 2015/07/09 18:13:45, Dan Beam wrote: > On 2015/07/08 19:39:52, michaelpg wrote: > > Not 100% clear on how focusing works, but could the element manage its own > focus > > state? > > it's possible this component could have it's own cr.ui.FocusRow, but I haven't > really thought about any of that yet (I'm going to add it back soon). > > I can remove column-type if you'd like, but I didn't see a huge issue with > leaving them for now. Acknowledged.
	15 <span id="name"></span>

	16 <span id="status"></span>

	17 </div>

	18 <div id="url-container">

	19 <a id="src-url" target="_blank" column-type="url"></a>

	20 </div>

	21 <div id="controls">

	22 <a is="action-link" id="show" column-type="show"

	23 i18n-content="control_showinfolder"></a>

	24 <a id="retry" column-type="retry" i18n-content="control_retry"

	25 download></a>

	26 <a is="action-link" id="pause" column-type="pause"

	27 i18n-content="control_pause"></a>

	28 <a is="action-link" id="resume" column-type="resume"

	29 i18n-content="control_resume"></a>

	30 <a is="action-link" id="safe-remove" column-type="remove"

	31 i18n-content="control_removefromlist"></a>

	32 <a is="action-link" id="cancel" column-type="cancel"

	33 i18n-content="control_cancel"></a>

	34 <span id="controlled-by"

	35 i18n-values=".innerHTML:control_by_extension"></span>

	36 </div>

	37 </div>

	38

	39 <div id="dangerous">

	40 <img id="dangerous-icon" alt="">

	41 <div id="description"></div>

	42 <div id="controls">

	43 <a is="action-link" id="restore" column-type="save"

	44 i18n-content="danger_restore"></a>

	45 <a is="action-link" id="dangerous-remove" column-type="discard"

	46 i18n-content="control_removefromlist"></a>

	47 </div>

	48 <button id="save" column-type="save"

	49 i18n-content="danger_save"></button>

	50 <button id="discard" column-type="discard"

	51 i18n-content="danger_discard"></button>

	52 </div>

	53 </template>

	54 <!-- TODO(dbeam): use <link rel="import"> instead to load these scripts. -->

	55 <script src="constants.js"></script>

	56 <script src="icon_loader.js"></script>

	57 <script src="item_view.js"></script>

	58 </dom-module>

OLD	NEW