Implement GetUploadStatusOperation on GData WAPI.

chrome/browser/google_apis/gdata_wapi_operations.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_GOOGLE_APIS_GDATA_WAPI_OPERATIONS_H_
 #define CHROME_BROWSER_GOOGLE_APIS_GDATA_WAPI_OPERATIONS_H_
 
 #include <string>
 #include <vector>
 
@@ skipping 548 matching lines @@
   // The parameters for the request. See ResumeUploadParams for the details.
   const int64 start_position_;
   const int64 end_position_;
   const int64 content_length_;
   const std::string content_type_;
   const scoped_refptr<net::IOBuffer> buf_;
 
   DISALLOW_COPY_AND_ASSIGN(ResumeUploadOperation);
 };
 
+//========================== GetUploadStatusOperation ==========================
+
+// This class performs the operation for getting the current upload status
+// of a file. This operation calls |callback| given via the constructor

[satorux1, 2013/02/07 06:54:13]

Let's drop " given via the constructor" as it's obvious.

[hidehiko, 2013/02/07 07:44:07]

Done.

+// with the range of the successfully uploaded data, or HTTP_SUCCESS or

[satorux1, 2013/02/07 06:54:13]

maybe it's cleaner to describe the two case separately like:

This result is passed to |callback| as follows:

- If a file has been completely uploaded to |upload_url|, |callback| is called
with HTTP_CREATED. The range parameters are unused.

- If a file has been partially uploaded to |upload_url|, |callback| is called
with HTTP_SUCCESS, with the range of the previously uploaded data.

[hidehiko, 2013/02/07 07:44:07]

Updated a bit more. How about this?

+// HTTP_CREATED if the whole data is uploaded successfully.
+class GetUploadStatusOperation : public UploadRangeOperationBase {
+ public:
+  // |callback| must not be null. See also UploadRangeOperationBase's
+  // constructor for more details.
+  // |content_length| is the whole data size to be uploaded, or -1 if it is
+  // unknown.
+  GetUploadStatusOperation(
+      OperationRegistry* registry,
+      net::URLRequestContextGetter* url_request_context_getter,
+      const UploadRangeCallback& callback,

[satorux1, 2013/02/07 06:54:13]

BTW, UploadRangeCallback takes scoped_ptr<ResourceEntry>, which we don't care
for this operation, right?

If so, I think we should not use  UploadRangeCallback. We should instead define
a new callback type. What do you think?

[hidehiko, 2013/02/07 07:44:07]

The ResourceEntry is used actually. Please see also
UploadRangeOperationBase::ProcessURLFetchResults and OnDataParsed.

[satorux1, 2013/02/07 07:58:59]

I thought ResourceEntry was necessary for ResumeUploadOperation, but not
GetUploadStatusOperation, as we only care about the status code and the range
here.

[hidehiko, 2013/02/07 08:37:56]

Acknowledged.

+      UploadMode load_mode,
+      const FilePath& drive_file_path,
+      const GURL& upload_url,
+      int64 content_length);
+  virtual ~GetUploadStatusOperation();
+
+ protected:
+  // UrlFetchOperationBase overrides.
+  virtual std::vector<std::string> GetExtraRequestHeaders() const OVERRIDE;
+
+ private:
+  const int64 content_length_;
+
+  DISALLOW_COPY_AND_ASSIGN(GetUploadStatusOperation);
+};
+
 }  // namespace google_apis
 
 #endif  // CHROME_BROWSER_GOOGLE_APIS_GDATA_WAPI_OPERATIONS_H_