Calling webview.focus() now works correctly

extensions/renderer/resources/guest_view/guest_view_container.js

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // This module implements the shared functionality for different guestview
 // containers, such as web_view, app_view, etc.
 
 var DocumentNatives = requireNative('document_natives');
 var GuestView = require('guestView').GuestView;
 var GuestViewInternalNatives = requireNative('guest_view_internal');
@@ skipping 93 matching lines @@
   this.element.addEventListener('focus', this.weakWrapper(function(e) {
     // Focus the BrowserPlugin when the GuestViewContainer takes focus.
     privates(this).internalElement.focus();
   }));
   this.element.addEventListener('blur', this.weakWrapper(function(e) {
     // Blur the BrowserPlugin when the GuestViewContainer loses focus.
     privates(this).internalElement.blur();
   }));
 };
 
+GuestViewContainer.prototype.focus = function() {
+  // Focus the internal element when focus() is called on the GuestView element.
+  privates(this).internalElement.focus();
+}
+
 GuestViewContainer.prototype.attachWindow$ = function() {
   if (!this.internalInstanceId) {
     return true;
   }
 
   this.guest.attach(this.internalInstanceId,
                     this.viewInstanceId,
                     this.buildParams());
   return true;
 };
@@ skipping 103 matching lines @@
                                       {extends: 'object', prototype: proto});
 
   delete proto.createdCallback;
   delete proto.attachedCallback;
   delete proto.detachedCallback;
   delete proto.attributeChangedCallback;
 };
 
 // Registers the guestview container as a custom element.
 // |guestViewContainerType| is the type of guestview container
-// (e.g.WebViewImpl).
+// (e.g. WebViewImpl).
 function registerGuestViewElement(guestViewContainerType) {
   var proto = $Object.create(HTMLElement.prototype);
 
   proto.createdCallback = function() {
     new guestViewContainerType(this);
   };
 
   proto.attachedCallback = function() {
     var internal = privates(this).internal;
     if (!internal) {
@@ skipping 17 matching lines @@
     var internal = privates(this).internal;
     if (!internal) {
       return;
     }
     internal.elementAttached = false;
     internal.internalInstanceId = 0;
     internal.guest.destroy();
     internal.onElementDetached();
   };
 
+  // Override |focus| to let |internal| handle it.
+  proto.focus = function() {

[Fady Samuel, 2015/07/08 14:38:11]

What about blur? Also does this pass existing focus tests?

[paulmeyer, 2015/07/08 20:19:50]

I do not believe that doing the same thing for blur would be meaningful, since
there is not the same issue of calling blur() on an already blurred webview
leading to something else suddenly becoming unblurred. It could be added for
consistency, though I am not sure if it is warranted in this case to add extra
code that isn't needed purely for consistency.

This does pass all existing focus tests.

+    var internal = privates(this).internal;
+    if (!internal) {
+      return;
+    }
+    internal.focus();
+  };
+
   // Let the specific view type add extra functionality to its custom element
   // through |proto|.
   if (guestViewContainerType.setupElement) {
     guestViewContainerType.setupElement(proto);
   }
 
   window[guestViewContainerType.VIEW_TYPE] =
       DocumentNatives.RegisterElement(
           guestViewContainerType.VIEW_TYPE.toLowerCase(),
           {prototype: proto});
 
   // Delete the callbacks so developers cannot call them and produce unexpected
   // behavior.
   delete proto.createdCallback;
   delete proto.attachedCallback;
   delete proto.detachedCallback;
   delete proto.attributeChangedCallback;
 }
 
 // Exports.
 exports.GuestViewContainer = GuestViewContainer;