Calling webview.focus() now works correctly

Calling webview.focus() now works correctly even when the webview is already focused. Previously, calling focus() on a webview that was already focused would unfocus the guest content in the webview.

BUG=503832, 501062
Committed: https://crrev.com/6476573b7d9099b04002736d90a078550c8651eb
Cr-Commit-Position: refs/heads/master@{#338852}

[paulmeyer, 2015-07-08 14:36:08]

paulmeyer@chromium.org changed reviewers:
+ lazyboy@chromium.org

[Fady Samuel, 2015-07-08 14:38:10]

fsamuel@chromium.org changed reviewers:
+ fsamuel@chromium.org

[Fady Samuel, 2015-07-08 14:38:11]

https://codereview.chromium.org/1224573006/diff/1/extensions/renderer/resourc...
File extensions/renderer/resources/guest_view/guest_view_container.js (right):

https://codereview.chromium.org/1224573006/diff/1/extensions/renderer/resourc...
extensions/renderer/resources/guest_view/guest_view_container.js:281:
proto.focus = function() {
What about blur? Also does this pass existing focus tests?

[paulmeyer, 2015-07-08 20:19:50]

https://codereview.chromium.org/1224573006/diff/1/extensions/renderer/resourc...
File extensions/renderer/resources/guest_view/guest_view_container.js (right):

https://codereview.chromium.org/1224573006/diff/1/extensions/renderer/resourc...
extensions/renderer/resources/guest_view/guest_view_container.js:281:
proto.focus = function() {
On 2015/07/08 14:38:11, Fady Samuel wrote:
> What about blur? Also does this pass existing focus tests?

I do not believe that doing the same thing for blur would be meaningful, since
there is not the same issue of calling blur() on an already blurred webview
leading to something else suddenly becoming unblurred. It could be added for
consistency, though I am not sure if it is warranted in this case to add extra
code that isn't needed purely for consistency.

This does pass all existing focus tests.

[Fady Samuel, 2015-07-08 20:21:57]

lgtm

[paulmeyer, 2015-07-08 20:22:13]

The CQ bit was checked by paulmeyer@chromium.org

[commit-bot: I haz the power, 2015-07-08 20:23:45]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1224573006/1

[commit-bot: I haz the power, 2015-07-08 22:33:26]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-07-08 22:33:27]

Try jobs failed on following builders:
  mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[paulmeyer, 2015-07-14 17:51:48]

The CQ bit was checked by paulmeyer@chromium.org

[paulmeyer, 2015-07-14 17:51:48]

The patchset sent to the CQ was uploaded after l-g-t-m from fsamuel@chromium.org
Link to the patchset: https://codereview.chromium.org/1224573006/#ps20001
(title: "Altered test to work on all platforms.")

[commit-bot: I haz the power, 2015-07-14 17:53:05]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1224573006/20001

[commit-bot: I haz the power, 2015-07-14 18:21:46]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-07-14 18:21:46]

Try jobs failed on following builders:
  win8_chromium_ng on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win8_chromium_ng/...)

[paulmeyer, 2015-07-15 13:09:09]

The CQ bit was checked by paulmeyer@chromium.org

[paulmeyer, 2015-07-15 13:09:09]

The patchset sent to the CQ was uploaded after l-g-t-m from fsamuel@chromium.org
Link to the patchset: https://codereview.chromium.org/1224573006/#ps40001
(title: "Rebased.")

[commit-bot: I haz the power, 2015-07-15 13:09:49]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1224573006/40001

[commit-bot: I haz the power, 2015-07-15 14:14:33]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-07-15 14:15:33]

Patchset 3 (id:??) landed as
https://crrev.com/6476573b7d9099b04002736d90a078550c8651eb
Cr-Commit-Position: refs/heads/master@{#338852}