Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(364)

Unified Diff: net/http/http_log_util.cc

Issue 1224553010: Replace base::str[n]casecmp with helper functions. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/dns/dns_response.cc ('k') | net/http/http_request_headers.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/http/http_log_util.cc
diff --git a/net/http/http_log_util.cc b/net/http/http_log_util.cc
index 0467fb605ab40ca7a5f4eeacd5c28bcbcc635ada..8e071e34109a7dd7c76ca6edae0f0d58b620c1ff 100644
--- a/net/http/http_log_util.cc
+++ b/net/http/http_log_util.cc
@@ -45,15 +45,15 @@ std::string ElideHeaderValueForNetLog(NetLogCaptureMode capture_mode,
// Note: this logic should be kept in sync with stripCookiesAndLoginInfo in
// chrome/browser/resources/net_internals/log_view_painter.js.
- if (!base::strcasecmp(header.c_str(), "set-cookie") ||
- !base::strcasecmp(header.c_str(), "set-cookie2") ||
- !base::strcasecmp(header.c_str(), "cookie") ||
- !base::strcasecmp(header.c_str(), "authorization") ||
- !base::strcasecmp(header.c_str(), "proxy-authorization")) {
+ if (base::EqualsCaseInsensitiveASCII(header, "set-cookie") ||
+ base::EqualsCaseInsensitiveASCII(header, "set-cookie2") ||
+ base::EqualsCaseInsensitiveASCII(header, "cookie") ||
+ base::EqualsCaseInsensitiveASCII(header, "authorization") ||
+ base::EqualsCaseInsensitiveASCII(header, "proxy-authorization")) {
redact_begin = value.begin();
redact_end = value.end();
- } else if (!base::strcasecmp(header.c_str(), "www-authenticate") ||
- !base::strcasecmp(header.c_str(), "proxy-authenticate")) {
+ } else if (base::EqualsCaseInsensitiveASCII(header, "www-authenticate") ||
+ base::EqualsCaseInsensitiveASCII(header, "proxy-authenticate")) {
// Look for authentication information from data received from the server
// in multi-round Negotiate authentication.
HttpAuthChallengeTokenizer challenge(value.begin(), value.end());
« no previous file with comments | « net/dns/dns_response.cc ('k') | net/http/http_request_headers.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698