chrome/test/chromedriver/performance_logger.cc - Issue 1224553010: Replace base::str[n]casecmp with helper functions.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/test/chromedriver/performance_logger.cc

Issue 1224553010: Replace base::str[n]casecmp with helper functions. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/test/chromedriver/performance_logger.cc

diff --git a/chrome/test/chromedriver/performance_logger.cc b/chrome/test/chromedriver/performance_logger.cc

index 37e66f40f280358a2aa49fabfc044d18fa134b43..f97385b6d9143c2a1ae15fb7408e3053200b2740 100644

--- a/chrome/test/chromedriver/performance_logger.cc

+++ b/chrome/test/chromedriver/performance_logger.cc

@@ -43,7 +43,8 @@ bool IsEnabled(const PerfLoggingPrefs::InspectorDomainStatus& domain_status) {

bool ShouldRequestTraceEvents(const std::string& command) {

for (size_t i_domain = 0; i_domain < arraysize(kRequestTraceCommands);

++i_domain) {

- if (base::strcasecmp(command.c_str(), kRequestTraceCommands[i_domain]) == 0)

+ if (base::EqualsCaseInsensitiveASCII(command,

+ kRequestTraceCommands[i_domain]))

return true;

}

return false;