Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1240)

Unified Diff: Source/core/inspector/InspectorDebuggerAgent.h

Issue 1224553008: [DevTools] Move Script and enums from ScriptDebugListener to V8Debugger. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | Source/core/inspector/InspectorDebuggerAgent.cpp » ('j') | Source/core/inspector/V8Debugger.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/inspector/InspectorDebuggerAgent.h
diff --git a/Source/core/inspector/InspectorDebuggerAgent.h b/Source/core/inspector/InspectorDebuggerAgent.h
index fbae2a659b9394f534750c8d0f393f5ebebd5270..36ea97ed18cda58551f308bef62fa1d12974b94b 100644
--- a/Source/core/inspector/InspectorDebuggerAgent.h
+++ b/Source/core/inspector/InspectorDebuggerAgent.h
@@ -206,7 +206,7 @@ protected:
virtual void enable();
virtual void disable();
- SkipPauseRequest didPause(ScriptState*, const ScriptValue& callFrames, const ScriptValue& exception, const Vector<String>& hitBreakpoints, bool isPromiseRejection) final;
+ V8Debugger::SkipPauseRequest didPause(ScriptState*, const ScriptValue& callFrames, const ScriptValue& exception, const Vector<String>& hitBreakpoints, bool isPromiseRejection) final;
void didContinue() final;
void reset();
void resetModifiedSources();
@@ -214,8 +214,8 @@ protected:
private:
bool checkEnabled(ErrorString*);
- SkipPauseRequest shouldSkipExceptionPause();
- SkipPauseRequest shouldSkipStepPause();
+ V8Debugger::SkipPauseRequest shouldSkipExceptionPause();
+ V8Debugger::SkipPauseRequest shouldSkipStepPause();
void schedulePauseOnNextStatementIfSteppingInto();
void cancelPauseOnNextStatement();
@@ -229,7 +229,7 @@ private:
void changeJavaScriptRecursionLevel(int step);
- void didParseSource(const ParsedScript&) final;
+ void didParseSource(const V8Debugger::ParsedScript&) final;
bool v8AsyncTaskEventsEnabled() const final;
void didReceiveV8AsyncTaskEvent(ScriptState*, const String& eventType, const String& eventName, int id) final;
bool v8PromiseEventsEnabled() const final;
@@ -244,7 +244,7 @@ private:
bool assertPaused(ErrorString*);
void clearBreakDetails();
- String sourceMapURLForScript(const Script&, CompileResult);
+ String sourceMapURLForScript(const V8Debugger::Script&, V8Debugger::CompileResult);
bool isCallStackEmptyOrBlackboxed();
bool isTopCallFrameBlackboxed();
@@ -255,7 +255,7 @@ private:
void increaseCachedSkipStackGeneration();
PassRefPtr<TypeBuilder::Debugger::ExceptionDetails> createExceptionDetails(v8::Isolate*, v8::Local<v8::Message>);
- typedef HashMap<String, Script> ScriptsMap;
+ typedef HashMap<String, V8Debugger::Script> ScriptsMap;
typedef HashMap<String, Vector<String>> BreakpointIdToDebuggerBreakpointIdsMap;
typedef HashMap<String, std::pair<String, BreakpointSource>> DebugServerBreakpointToBreakpointIdAndSourceMap;
« no previous file with comments | « no previous file | Source/core/inspector/InspectorDebuggerAgent.cpp » ('j') | Source/core/inspector/V8Debugger.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698