third_party/android_customtabs/README.chromium - Issue 1224553003: customtabs: Convert to the new AIDL interface.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/android_customtabs/README.chromium

Issue 1224553003: customtabs: Convert to the new AIDL interface. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Update to external patch #16, rebase and update constants. Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 Name: Android Open Source Project - App Compat Library

	2 URL: https://android.googlesource.com/platform/frameworks/support

	3 Version: unknown

	4 License: Apache 2.0

	5 Security Critical: no

	6

	7 Description:

	8 Part of the Custom Tabs support library.
	pasko 2015/07/09 13:37:13 If I were a third_party reviewer, I would not be h If I were a third_party reviewer, I would not be happy with it because this needs an extra explanation what part is imported, the fact that we commit to removing this dependency soon, etc. The review process is not the most lightweight (eng/oss/security): https://www.chromium.org/developers/adding-3rd-party-libraries We are not importing anything from a third party, the code is authored by our team of chromium committers, and we can put it under the same license as all chromium for the temporary period of time until we update the android support library we use, and the equivalent code there gets used.
	9

	10 Local Modifications:

	11 - Minor changes to the AIDL files:

	12 - Add common.aidl

	13 - Remove the "import" statement for the callback from the service file.

	14

OLD	NEW