Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Issue 1224553002: win: Let CRASH forcibly crash process after __debugbreak. (Closed)

Created:
5 years, 5 months ago by Nico
Modified:
5 years, 5 months ago
Reviewers:
tkent
CC:
blink-reviews, blink-reviews-wtf_chromium.org, Mikhail, Sam McNally, Reid Kleckner
Target Ref:
refs/remotes/origin/master
Project:
blink
Visibility:
Public.

Description

win: Let CRASH forcibly crash process after __debugbreak. That's what CRASH's documentation asks for. In a debugger, one could simply continue after a __debugbreak, in contradiction to what CRASH's documentation requires. This is a follow-up to https://codereview.chromium.org/1207323004/ BUG=504698 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=198288

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -5 lines) Patch
M Source/wtf/Assertions.h View 1 2 1 chunk +1 line, -5 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Nico
5 years, 5 months ago (2015-07-05 23:34:23 UTC) #2
tkent
lgtm
5 years, 5 months ago (2015-07-05 23:47:42 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1224553002/40001
5 years, 5 months ago (2015-07-05 23:47:52 UTC) #5
commit-bot: I haz the power
5 years, 5 months ago (2015-07-06 00:19:24 UTC) #6
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=198288

Powered by Google App Engine
This is Rietveld 408576698