Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1391)

Unified Diff: net/http/http_transaction.h

Issue 122453002: Allows deferral of a URLRequest just before talking to the network, at (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Potential fix of a memory leak due to a reference cycle. Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/http/http_transaction.h
diff --git a/net/http/http_transaction.h b/net/http/http_transaction.h
index 3776998259af3f3d5223ea971922d288f5921988..f4a8f76fba0a750cba7ec16e8b4546f7534eae8c 100644
--- a/net/http/http_transaction.h
+++ b/net/http/http_transaction.h
@@ -28,6 +28,9 @@ class X509Certificate;
// answered. Cookies are assumed to be managed by the caller.
class NET_EXPORT_PRIVATE HttpTransaction {
public:
+ // The bool* is used to inform the caller if it needs to defer or not.
mmenke 2014/01/07 19:44:05 I think this could be clearer. Maybe something li
jkarlin 2014/01/07 20:10:03 Done.
+ typedef base::Callback<void(bool*)> BeforeNetworkStartCallback;
+
// Stops any pending IO and destroys the transaction object.
virtual ~HttpTransaction() {}
@@ -144,6 +147,13 @@ class NET_EXPORT_PRIVATE HttpTransaction {
// Start(). Ownership of |create_helper| remains with the caller.
virtual void SetWebSocketHandshakeStreamCreateHelper(
WebSocketHandshakeStreamBase::CreateHelper* create_helper) = 0;
+
+ // Set the callback to receive notification just before network use.
+ virtual void SetBeforeNetworkStartCallback(
+ const BeforeNetworkStartCallback& callback) = 0;
+
+ // Resumes the transaction after being deferred.
+ virtual int ResumeNetworkStart() = 0;
};
} // namespace net

Powered by Google App Engine
This is Rietveld 408576698