src/array.js - Issue 1224523002: Avoid converting key to string for deleting of elements

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/array.js

Issue 1224523002: Avoid converting key to string for deleting of elements (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/array.js

diff --git a/src/array.js b/src/array.js

index 9ecf0ac627fe30d914ea4a06ac32476afe8062f2..7baabf83610c3c333eb13b9a5463c652ccaa3839 100644

--- a/src/array.js

+++ b/src/array.js

@@ -478,7 +478,7 @@ function ArrayPop() {

n--;

var value = array[n];

- Delete(array, $toName(n), true);

+ Delete(array, n, true);

array.length = n;

return value;

}

« no previous file with comments | « src/api.cc ('k') | src/messages.h » ('j') | no next file with comments »