Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1610)

Side by Side Diff: src/objects.cc

Issue 1224523002: Avoid converting key to string for deleting of elements (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/messages.h ('k') | src/runtime.js » ('j') | src/v8natives.js » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 the V8 project authors. All rights reserved. 1 // Copyright 2013 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include <iomanip> 5 #include <iomanip>
6 #include <sstream> 6 #include <sstream>
7 7
8 #include "src/v8.h" 8 #include "src/v8.h"
9 9
10 #include "src/accessors.h" 10 #include "src/accessors.h"
(...skipping 5212 matching lines...) Expand 10 before | Expand all | Expand 10 after
5223 } 5223 }
5224 } 5224 }
5225 5225
5226 return it->factory()->true_value(); 5226 return it->factory()->true_value();
5227 } 5227 }
5228 5228
5229 5229
5230 MaybeHandle<Object> JSReceiver::DeleteElement(Handle<JSReceiver> object, 5230 MaybeHandle<Object> JSReceiver::DeleteElement(Handle<JSReceiver> object,
5231 uint32_t index, 5231 uint32_t index,
5232 LanguageMode language_mode) { 5232 LanguageMode language_mode) {
5233 LookupIterator it(object->GetIsolate(), object, index); 5233 LookupIterator it(object->GetIsolate(), object, index,
5234 LookupIterator::HIDDEN);
5234 return DeleteProperty(&it, language_mode); 5235 return DeleteProperty(&it, language_mode);
5235 } 5236 }
5236 5237
5237 5238
5238 MaybeHandle<Object> JSReceiver::DeleteProperty(Handle<JSReceiver> object, 5239 MaybeHandle<Object> JSReceiver::DeleteProperty(Handle<JSReceiver> object,
5239 Handle<Name> name, 5240 Handle<Name> name,
5240 LanguageMode language_mode) { 5241 LanguageMode language_mode) {
5241 LookupIterator it(object, name, LookupIterator::HIDDEN); 5242 LookupIterator it(object, name, LookupIterator::HIDDEN);
5242 return JSObject::DeleteProperty(&it, language_mode); 5243 return JSObject::DeleteProperty(&it, language_mode);
5243 } 5244 }
(...skipping 10857 matching lines...) Expand 10 before | Expand all | Expand 10 after
16101 Handle<Object> new_value) { 16102 Handle<Object> new_value) {
16102 if (cell->value() != *new_value) { 16103 if (cell->value() != *new_value) {
16103 cell->set_value(*new_value); 16104 cell->set_value(*new_value);
16104 Isolate* isolate = cell->GetIsolate(); 16105 Isolate* isolate = cell->GetIsolate();
16105 cell->dependent_code()->DeoptimizeDependentCodeGroup( 16106 cell->dependent_code()->DeoptimizeDependentCodeGroup(
16106 isolate, DependentCode::kPropertyCellChangedGroup); 16107 isolate, DependentCode::kPropertyCellChangedGroup);
16107 } 16108 }
16108 } 16109 }
16109 } // namespace internal 16110 } // namespace internal
16110 } // namespace v8 16111 } // namespace v8
OLDNEW
« no previous file with comments | « src/messages.h ('k') | src/runtime.js » ('j') | src/v8natives.js » ('J')

Powered by Google App Engine
This is Rietveld 408576698