Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(218)

Issue 1224523002: Avoid converting key to string for deleting of elements (Closed)

Created:
5 years, 5 months ago by Toon Verwaest
Modified:
5 years, 5 months ago
Reviewers:
Jakob Kummerow
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Avoid converting key to string for deleting of elements Additionally rips out (now) unnecessary duplicate code in DefineArrayProperty. BUG= Committed: https://crrev.com/d5335cba314dbef8a6d090703efcb33fe4009676 Cr-Commit-Position: refs/heads/master@{#29450}

Patch Set 1 #

Total comments: 1

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+80 lines, -94 lines) Patch
M src/api.cc View 1 2 2 chunks +2 lines, -20 lines 0 comments Download
M src/array.js View 1 chunk +1 line, -1 line 0 comments Download
M src/messages.h View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M src/objects.cc View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M src/runtime.js View 1 2 1 chunk +1 line, -1 line 0 comments Download
M src/runtime/runtime.h View 1 2 1 chunk +4 lines, -0 lines 0 comments Download
M src/runtime/runtime-object.cc View 1 2 2 chunks +20 lines, -3 lines 0 comments Download
M src/v8natives.js View 1 1 chunk +1 line, -66 lines 0 comments Download
M test/mjsunit/messages.js View 1 chunk +1 line, -1 line 0 comments Download
M test/test262-es6/test262-es6.status View 1 2 3 1 chunk +24 lines, -0 lines 0 comments Download
M test/test262/test262.status View 1 2 3 1 chunk +24 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (5 generated)
Toon Verwaest
ptal
5 years, 5 months ago (2015-07-02 12:59:04 UTC) #2
Jakob Kummerow
LGTM https://codereview.chromium.org/1224523002/diff/1/src/v8natives.js File src/v8natives.js (right): https://codereview.chromium.org/1224523002/diff/1/src/v8natives.js#newcode806 src/v8natives.js:806: // property, hence we use generated code throughout ...
5 years, 5 months ago (2015-07-02 13:24:53 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1224523002/20001
5 years, 5 months ago (2015-07-02 13:31:32 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: v8_linux_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_rel/builds/7244)
5 years, 5 months ago (2015-07-02 14:15:59 UTC) #8
Jakob Kummerow
lgtm
5 years, 5 months ago (2015-07-02 15:01:49 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1224523002/60001
5 years, 5 months ago (2015-07-02 15:02:19 UTC) #11
commit-bot: I haz the power
Committed patchset #4 (id:60001)
5 years, 5 months ago (2015-07-02 15:27:27 UTC) #12
commit-bot: I haz the power
5 years, 5 months ago (2015-07-02 15:27:38 UTC) #13
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/d5335cba314dbef8a6d090703efcb33fe4009676
Cr-Commit-Position: refs/heads/master@{#29450}

Powered by Google App Engine
This is Rietveld 408576698