Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(204)

Issue 1224463004: Convert gl_unittests to run exclusively on Swarming (Closed)

Created:
5 years, 5 months ago by Nico
Modified:
5 years, 5 months ago
Reviewers:
M-A Ruel
CC:
chromium-reviews, David Yen
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Convert gl_unittests to run exclusively on Swarming It already had a .isolate file. 0 configs already ran on Swarming 22 used to run locally and were converted: - chromium.fyi.json: ClangToTLinux tester - chromium.fyi.json: ClangToTLinuxASan tester - chromium.fyi.json: ClangToTMac tester - chromium.fyi.json: ClangToTMacASan tester - chromium.fyi.json: Linux Trusty - chromium.fyi.json: Linux Trusty (dbg) - chromium.linux.json: Linux Tests - chromium.linux.json: Linux Tests (dbg)(1) - chromium.linux.json: Linux Tests (dbg)(1)(32) - chromium.mac.json: Mac10.6 Tests - chromium.mac.json: Mac10.8 Tests - chromium.mac.json: Mac10.9 Tests - chromium.mac.json: Mac10.9 Tests (dbg) - chromium.memory.fyi.json: Linux ChromeOS MSan Tests - chromium.memory.fyi.json: Linux MSan Tests - chromium.memory.fyi.json: Linux TSan Tests - chromium.memory.json: Linux ASan LSan Tests (1) - chromium.memory.json: Linux Chromium OS ASan LSan Tests (1) - chromium.win.json: Vista Tests (1) - chromium.win.json: Win 7 Tests x64 (1) - chromium.win.json: Win7 Tests (1) - chromium.win.json: XP Tests (1) Ran: ./manage.py --convert gl_unittests BUG=98637 Committed: https://crrev.com/bbc8c3c1aae94557a90c8d7d73e94af233eff79e Cr-Commit-Position: refs/heads/master@{#337318}

Patch Set 1 #

Patch Set 2 : i keep forgetting this #

Patch Set 3 : i keep forgetting this too #

Total comments: 4
Unified diffs Side-by-side diffs Delta from patch set Stats (+67 lines, -0 lines) Patch
M build/gn_migration.gypi View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M testing/buildbot/chromium.fyi.json View 6 chunks +18 lines, -0 lines 4 comments Download
M testing/buildbot/chromium.linux.json View 3 chunks +9 lines, -0 lines 0 comments Download
M testing/buildbot/chromium.mac.json View 4 chunks +12 lines, -0 lines 0 comments Download
M testing/buildbot/chromium.memory.json View 2 chunks +6 lines, -0 lines 0 comments Download
M testing/buildbot/chromium.memory.fyi.json View 3 chunks +9 lines, -0 lines 0 comments Download
M testing/buildbot/chromium.win.json View 4 chunks +12 lines, -0 lines 0 comments Download

Messages

Total messages: 15 (2 generated)
Nico
5 years, 5 months ago (2015-07-02 19:52:57 UTC) #2
Nico
5 years, 5 months ago (2015-07-02 19:53:20 UTC) #3
M-A Ruel
gl_unittests.isolate looks incomplete, I don't think it'll run. I'd assume it'll likely need osmesa, we'll ...
5 years, 5 months ago (2015-07-02 20:15:01 UTC) #4
Nico
https://codereview.chromium.org/1224463004/diff/40001/testing/buildbot/chromium.fyi.json File testing/buildbot/chromium.fyi.json (right): https://codereview.chromium.org/1224463004/diff/40001/testing/buildbot/chromium.fyi.json#newcode258 testing/buildbot/chromium.fyi.json:258: "swarming": { On 2015/07/02 20:15:00, M-A Ruel wrote: > ...
5 years, 5 months ago (2015-07-02 20:16:28 UTC) #5
M-A Ruel
https://codereview.chromium.org/1224463004/diff/40001/testing/buildbot/chromium.fyi.json File testing/buildbot/chromium.fyi.json (right): https://codereview.chromium.org/1224463004/diff/40001/testing/buildbot/chromium.fyi.json#newcode258 testing/buildbot/chromium.fyi.json:258: "swarming": { On 2015/07/02 20:16:28, Nico wrote: > On ...
5 years, 5 months ago (2015-07-02 20:18:48 UTC) #6
Nico
https://codereview.chromium.org/1224463004/diff/40001/testing/buildbot/chromium.fyi.json File testing/buildbot/chromium.fyi.json (right): https://codereview.chromium.org/1224463004/diff/40001/testing/buildbot/chromium.fyi.json#newcode258 testing/buildbot/chromium.fyi.json:258: "swarming": { On 2015/07/02 20:18:48, M-A Ruel wrote: > ...
5 years, 5 months ago (2015-07-02 20:21:08 UTC) #7
M-A Ruel
On 2015/07/02 20:21:08, Nico wrote: > https://codereview.chromium.org/1224463004/diff/40001/testing/buildbot/chromium.fyi.json > File testing/buildbot/chromium.fyi.json (right): > > https://codereview.chromium.org/1224463004/diff/40001/testing/buildbot/chromium.fyi.json#newcode258 > ...
5 years, 5 months ago (2015-07-02 20:40:08 UTC) #8
Nico
On 2015/07/02 20:40:08, M-A Ruel wrote: > On 2015/07/02 20:21:08, Nico wrote: > > > ...
5 years, 5 months ago (2015-07-02 20:45:02 UTC) #9
Nico
Ok, gl_unittests seems to pass on the bots, ptal. (I would've been surprised if they ...
5 years, 5 months ago (2015-07-02 20:45:42 UTC) #10
M-A Ruel
lgtm
5 years, 5 months ago (2015-07-03 13:56:27 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1224463004/40001
5 years, 5 months ago (2015-07-03 15:36:03 UTC) #13
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 5 months ago (2015-07-03 16:38:27 UTC) #14
commit-bot: I haz the power
5 years, 5 months ago (2015-07-03 16:39:19 UTC) #15
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/bbc8c3c1aae94557a90c8d7d73e94af233eff79e
Cr-Commit-Position: refs/heads/master@{#337318}

Powered by Google App Engine
This is Rietveld 408576698