Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(168)

Issue 1224453003: Convert ppapi_unittests to run exclusively on Swarming (Closed)

Created:
5 years, 5 months ago by Nico
Modified:
5 years, 5 months ago
Reviewers:
raymes, M-A Ruel
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Convert ppapi_unittests to run exclusively on Swarming 0 configs already ran on Swarming 46 used to run locally and were converted: - chromium.chromiumos.json: Linux ChromiumOS Ozone Tests (1) - chromium.chromiumos.json: Linux ChromiumOS Tests (1) - chromium.chromiumos.json: Linux ChromiumOS Tests (dbg)(1) - chromium.fyi.json: ClangToTLinux tester - chromium.fyi.json: ClangToTLinuxASan tester - chromium.fyi.json: ClangToTMac tester - chromium.fyi.json: ClangToTMacASan tester - chromium.fyi.json: ClangToTWin tester - chromium.fyi.json: ClangToTWin(dbg) tester - chromium.fyi.json: ClangToTWin(dll) tester - chromium.fyi.json: ClangToTWin64 tester - chromium.fyi.json: ClangToTWin64(dbg) tester - chromium.fyi.json: ClangToTWin64(dll) tester - chromium.fyi.json: CrWinAsan tester - chromium.fyi.json: CrWinAsan(dll) tester - chromium.fyi.json: CrWinClang tester - chromium.fyi.json: CrWinClang(dbg) tester - chromium.fyi.json: CrWinClang(shared) tester - chromium.fyi.json: CrWinClang64 tester - chromium.fyi.json: CrWinClang64(dbg) tester - chromium.fyi.json: CrWinClang64(dll) tester - chromium.fyi.json: CrWinClangLLD tester - chromium.fyi.json: Linux Trusty - chromium.fyi.json: Linux Trusty (dbg) - chromium.linux.json: Cast Linux - chromium.linux.json: Linux Tests - chromium.linux.json: Linux Tests (dbg)(1) - chromium.linux.json: Linux Tests (dbg)(1)(32) - chromium.mac.json: Mac10.10 Tests - chromium.mac.json: Mac10.6 Tests - chromium.mac.json: Mac10.8 Tests - chromium.mac.json: Mac10.9 Tests - chromium.mac.json: Mac10.9 Tests (dbg) - chromium.memory.fyi.json: Linux ChromeOS MSan Tests - chromium.memory.fyi.json: Linux MSan Tests - chromium.memory.fyi.json: Linux TSan Tests - chromium.memory.json: Linux ASan LSan Tests (1) - chromium.memory.json: Linux Chromium OS ASan LSan Tests (1) - chromium.memory.json: Mac ASan 64 Tests (1) - chromium.webkit.json: Linux ChromiumOS Tests (1) - chromium.webkit.json: Linux ChromiumOS Tests (dbg)(1) - chromium.win.json: Vista Tests (1) - chromium.win.json: Win 7 Tests x64 (1) - chromium.win.json: Win7 Tests (1) - chromium.win.json: Win7 Tests (dbg)(1) - chromium.win.json: XP Tests (1) Ran: ./manage.py --convert ppapi_unittests BUG=98637 Committed: https://crrev.com/0e660cb50e66dc9d5e794d63b4bd72079acefc2e Cr-Commit-Position: refs/heads/master@{#337272}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+157 lines, -4 lines) Patch
M build/gn_migration.gypi View 1 chunk +1 line, -0 lines 0 comments Download
M ppapi/ppapi_tests.gypi View 1 chunk +15 lines, -0 lines 0 comments Download
A + ppapi/ppapi_unittests.isolate View 1 chunk +3 lines, -4 lines 0 comments Download
M testing/buildbot/chromium.chromiumos.json View 3 chunks +9 lines, -0 lines 0 comments Download
M testing/buildbot/chromium.fyi.json View 21 chunks +63 lines, -0 lines 0 comments Download
M testing/buildbot/chromium.linux.json View 4 chunks +12 lines, -0 lines 0 comments Download
M testing/buildbot/chromium.mac.json View 5 chunks +15 lines, -0 lines 0 comments Download
M testing/buildbot/chromium.memory.json View 3 chunks +9 lines, -0 lines 0 comments Download
M testing/buildbot/chromium.memory.fyi.json View 3 chunks +9 lines, -0 lines 0 comments Download
M testing/buildbot/chromium.webkit.json View 2 chunks +6 lines, -0 lines 0 comments Download
M testing/buildbot/chromium.win.json View 5 chunks +15 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (2 generated)
Nico
raymes: ppapi/ maruel: testing/
5 years, 5 months ago (2015-07-03 01:02:45 UTC) #2
raymes
I don't really understand this :P I defer to maruel@ (if he does) and happy ...
5 years, 5 months ago (2015-07-03 01:16:10 UTC) #3
Nico
See "[chromium-dev] Faster, Parallel CI via Swarming - Isolated testing burn down chart". The idea ...
5 years, 5 months ago (2015-07-03 01:30:35 UTC) #4
raymes
rubberstamp lgtm
5 years, 5 months ago (2015-07-03 01:38:46 UTC) #5
M-A Ruel
lgtm
5 years, 5 months ago (2015-07-03 01:54:56 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1224453003/1
5 years, 5 months ago (2015-07-03 02:01:13 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 5 months ago (2015-07-03 02:04:29 UTC) #9
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/0e660cb50e66dc9d5e794d63b4bd72079acefc2e Cr-Commit-Position: refs/heads/master@{#337272}
5 years, 5 months ago (2015-07-03 02:05:24 UTC) #10
Derek Bruening
5 years, 5 months ago (2015-07-05 03:43:25 UTC) #11
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1218743005/ by bruening@chromium.org.

The reason for reverting is: Results in multiple data races reported on
ppapi_unittests by ThreadSanitizer.

Powered by Google App Engine
This is Rietveld 408576698