Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1124)

Issue 1224453002: Changing name of has_transpareny_in_palette to has_transparency_in_tRNS (Closed)

Created:
5 years, 5 months ago by emmaleer
Modified:
5 years, 5 months ago
Reviewers:
msarett, scroggo
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Changing name of has_transpareny_in_palette to has_transparency_in_tRNS This function checks for transparency info in the tRNS chunk Other images besides paletted images can have tRNS chunks, including Gray8 and RGB has_transparency_in_tRNS is a better name for the function BUG=skia: Committed: https://skia.googlesource.com/skia/+/21cea726e743aa05720adea456f26fcd58318505

Patch Set 1 #

Patch Set 2 : fixing merge conflict #

Patch Set 3 : fixing merge conflict #

Patch Set 4 : fixing merge conflict #

Patch Set 5 : calling has_transparency_in_tRNS #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -5 lines) Patch
M src/codec/SkCodec_libpng.cpp View 1 2 3 4 3 chunks +6 lines, -5 lines 0 comments Download

Messages

Total messages: 21 (11 generated)
emmaleer
5 years, 5 months ago (2015-07-01 22:42:54 UTC) #2
scroggo
nit: has_transparency_in_palette LGTm
5 years, 5 months ago (2015-07-07 12:59:09 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1224453002/1
5 years, 5 months ago (2015-07-08 01:30:55 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Debug-Trybot on client.skia (JOB_FAILED, http://build.chromium.org/p/client.skia/builders/Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Debug-Trybot/builds/1815) Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-Shared-Trybot on client.skia (JOB_FAILED, ...
5 years, 5 months ago (2015-07-08 01:31:38 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1224453002/40001
5 years, 5 months ago (2015-07-10 14:21:45 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Debug-Trybot on client.skia (JOB_FAILED, http://build.chromium.org/p/client.skia/builders/Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Debug-Trybot/builds/1894) Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-Shared-Trybot on client.skia (JOB_FAILED, ...
5 years, 5 months ago (2015-07-10 14:22:18 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1224453002/60001
5 years, 5 months ago (2015-07-10 14:33:06 UTC) #15
commit-bot: I haz the power
Try jobs failed on following builders: Build-Ubuntu-GCC-Arm64-Debug-Android-Trybot on client.skia.compile (JOB_FAILED, http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu-GCC-Arm64-Debug-Android-Trybot/builds/284) Build-Ubuntu-GCC-Arm7-Debug-Android-Trybot on client.skia.compile (JOB_FAILED, ...
5 years, 5 months ago (2015-07-10 14:33:57 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1224453002/80001
5 years, 5 months ago (2015-07-10 14:40:44 UTC) #20
commit-bot: I haz the power
5 years, 5 months ago (2015-07-10 14:48:06 UTC) #21
Message was sent while issue was closed.
Committed patchset #5 (id:80001) as
https://skia.googlesource.com/skia/+/21cea726e743aa05720adea456f26fcd58318505

Powered by Google App Engine
This is Rietveld 408576698