Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(938)

Unified Diff: dart/tools/test.dart

Issue 122443003: Added PkgBuildTestSuite (aka 'pkgbuild') (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: dart/tools/test.dart
diff --git a/dart/tools/test.dart b/dart/tools/test.dart
index b7afb77fb9fe5ae5592350d774100bfc733ede2c..a8cd20c1f654b4c4b99f5bb251e566191db43276 100755
--- a/dart/tools/test.dart
+++ b/dart/tools/test.dart
@@ -191,6 +191,16 @@ void testConfigurations(List<Map> configurations) {
if (key == 'analyze_library') {
testSuites.add(new AnalyzeLibraryTestSuite(conf));
}
+ } else if (conf['compiler'] == 'none' &&
+ conf['runtime'] == 'vm' &&
+ key == 'pkgbuild') {
+ if (!conf['use_sdk']) {
+ print("Running the 'pkgbuild' test suite requires "
+ "passing the '--use-sdk' to test.py");
+ exit(1);
Bob Nystrom 2014/01/07 17:13:43 Instead of making this an error, why not just have
kustermann 2014/01/10 15:48:05 Because setting use_sdk will change the configurat
+ }
+ testSuites.add(
+ new PkgBuildTestSuite(conf, 'pkgbuild', 'pkg/pkgbuild.status'));
}
}

Powered by Google App Engine
This is Rietveld 408576698