Index: content/browser/renderer_host/render_view_host_delegate.h |
diff --git a/content/browser/renderer_host/render_view_host_delegate.h b/content/browser/renderer_host/render_view_host_delegate.h |
index 9c1edce2de4597bb461e1d1190738074f78cd802..ad1029c160b4d666c8f4eaf31a2315392fea2e7b 100644 |
--- a/content/browser/renderer_host/render_view_host_delegate.h |
+++ b/content/browser/renderer_host/render_view_host_delegate.h |
@@ -196,9 +196,9 @@ class CONTENT_EXPORT RenderViewHostDelegate { |
virtual void LostMouseLock() {} |
// The page is trying to open a new page (e.g. a popup window). The window |
- // should be created associated with the given |route_id| in process |
- // |render_process_id|, but it should not be shown yet. That should happen in |
- // response to ShowCreatedWindow. |
+ // should be created associated with the given |route_id| in the process of |
+ // |source_site_instance|, but it should not be shown yet. That |
+ // should happen in response to ShowCreatedWindow. |
// |params.window_container_type| describes the type of RenderViewHost |
// container that is requested -- in particular, the window.open call may |
// have specified 'background' and 'persistent' in the feature string. |
@@ -208,8 +208,12 @@ class CONTENT_EXPORT RenderViewHostDelegate { |
// |
// Note: this is not called "CreateWindow" because that will clash with |
// the Windows function which is actually a #define. |
+ // |
+ // TODO(alexmos): This should be moved to RenderFrameHostDelegate, and the |
+ // corresponding IPC message should be sent by the RenderFrame creating the |
+ // new window. |
virtual void CreateNewWindow( |
- int render_process_id, |
+ SiteInstance* source_site_instance, |
int route_id, |
int main_frame_route_id, |
const ViewHostMsg_CreateWindow_Params& params, |