OOPIF: Fix window.open to work from frames with remote parent.

content/test/content_browser_test_utils_internal.h

Index: content/test/content_browser_test_utils_internal.h
diff --git a/content/test/content_browser_test_utils_internal.h b/content/test/content_browser_test_utils_internal.h
index 4486d14b5c5dd20502f7f2fdb3e7dbba6f0f489b..518b0e6e969e8258a59aa1b81d98932a8969ebbd 100644
--- a/content/test/content_browser_test_utils_internal.h
+++ b/content/test/content_browser_test_utils_internal.h
@@ -14,12 +14,14 @@
 #include <vector>
 
 #include "base/basictypes.h"
+#include "content/public/test/browser_test_utils.h"

[Paweł Hajdan Jr., 2015/07/15 17:30:33]

Why is this needed?

[alexmos, 2015/07/15 17:40:23]

For internal::ToRenderFrameHost, which is used in OpenPopup's first argument.

[Paweł Hajdan Jr., 2015/07/15 17:50:15]

Oh. internal:: suggests it should not be used outside of that file. However, I
see no reason for that (FWIW it was added in
https://chromiumcodereview.appspot.com/11753009).

Could you remove the internal namespace from
content/public/test/browser_test_utils.h and forward-declare ToRenderFrameHost
in content/test/content_browser_test_utils_internal.h ?

[alexmos, 2015/07/15 18:29:04]

Done.  Good idea.

 
 class GURL;
 
 namespace content {
 
 class FrameTreeNode;
+class Shell;
 class SiteInstance;
 
 // Navigates the frame represented by |node| to |url|, blocking until the
@@ -65,6 +67,15 @@ class FrameTreeVisualizer {
   DISALLOW_COPY_AND_ASSIGN(FrameTreeVisualizer);
 };
 
+// Uses window.open to open a popup from the frame |opener| with the specified
+// |url| and |name|.   Waits for the navigation to |url| to finish and then
+// returns the new popup's Shell.  Note that since this navigation to |url| is
+// renderer-initiated, it won't cause a process swap unless used in
+// --site-per-process mode.
+Shell* OpenPopup(const internal::ToRenderFrameHost& opener,
+                 const GURL& url,
+                 const std::string& name);
+
 }  // namespace content
 
 #endif  // CONTENT_TEST_CONTENT_BROWSER_TEST_UTILS_INTERNAL_H_