Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(111)

Side by Side Diff: content/browser/frame_host/interstitial_page_impl.cc

Issue 1224363002: OOPIF: Fix window.open to work from frames with remote parent. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "content/browser/frame_host/interstitial_page_impl.h" 5 #include "content/browser/frame_host/interstitial_page_impl.h"
6 6
7 #include <vector> 7 #include <vector>
8 8
9 #include "base/bind.h" 9 #include "base/bind.h"
10 #include "base/compiler_specific.h" 10 #include "base/compiler_specific.h"
(...skipping 727 matching lines...) Expand 10 before | Expand all | Expand 10 after
738 738
739 void InterstitialPageImpl::DontCreateViewForTesting() { 739 void InterstitialPageImpl::DontCreateViewForTesting() {
740 create_view_ = false; 740 create_view_ = false;
741 } 741 }
742 742
743 gfx::Rect InterstitialPageImpl::GetRootWindowResizerRect() const { 743 gfx::Rect InterstitialPageImpl::GetRootWindowResizerRect() const {
744 return gfx::Rect(); 744 return gfx::Rect();
745 } 745 }
746 746
747 void InterstitialPageImpl::CreateNewWindow( 747 void InterstitialPageImpl::CreateNewWindow(
748 int render_process_id, 748 SiteInstance* source_site_instance,
749 int route_id, 749 int route_id,
750 int main_frame_route_id, 750 int main_frame_route_id,
751 const ViewHostMsg_CreateWindow_Params& params, 751 const ViewHostMsg_CreateWindow_Params& params,
752 SessionStorageNamespace* session_storage_namespace) { 752 SessionStorageNamespace* session_storage_namespace) {
753 NOTREACHED() << "InterstitialPage does not support showing popups yet."; 753 NOTREACHED() << "InterstitialPage does not support showing popups yet.";
754 } 754 }
755 755
756 void InterstitialPageImpl::CreateNewWidget(int render_process_id, 756 void InterstitialPageImpl::CreateNewWidget(int render_process_id,
757 int route_id, 757 int route_id,
758 blink::WebPopupType popup_type) { 758 blink::WebPopupType popup_type) {
(...skipping 171 matching lines...) Expand 10 before | Expand all | Expand 10 after
930 void InterstitialPageImpl::UnderlyingContentObserver::NavigationEntryCommitted( 930 void InterstitialPageImpl::UnderlyingContentObserver::NavigationEntryCommitted(
931 const LoadCommittedDetails& load_details) { 931 const LoadCommittedDetails& load_details) {
932 interstitial_->OnNavigatingAwayOrTabClosing(); 932 interstitial_->OnNavigatingAwayOrTabClosing();
933 } 933 }
934 934
935 void InterstitialPageImpl::UnderlyingContentObserver::WebContentsDestroyed() { 935 void InterstitialPageImpl::UnderlyingContentObserver::WebContentsDestroyed() {
936 interstitial_->OnNavigatingAwayOrTabClosing(); 936 interstitial_->OnNavigatingAwayOrTabClosing();
937 } 937 }
938 938
939 } // namespace content 939 } // namespace content
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698