Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(111)

Side by Side Diff: content/browser/frame_host/interstitial_page_impl.cc

Issue 1224363002: OOPIF: Fix window.open to work from frames with remote parent. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Remove internal:: from ToRenderFrameHost Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "content/browser/frame_host/interstitial_page_impl.h" 5 #include "content/browser/frame_host/interstitial_page_impl.h"
6 6
7 #include <vector> 7 #include <vector>
8 8
9 #include "base/bind.h" 9 #include "base/bind.h"
10 #include "base/compiler_specific.h" 10 #include "base/compiler_specific.h"
(...skipping 737 matching lines...) Expand 10 before | Expand all | Expand 10 after
748 748
749 void InterstitialPageImpl::DontCreateViewForTesting() { 749 void InterstitialPageImpl::DontCreateViewForTesting() {
750 create_view_ = false; 750 create_view_ = false;
751 } 751 }
752 752
753 gfx::Rect InterstitialPageImpl::GetRootWindowResizerRect() const { 753 gfx::Rect InterstitialPageImpl::GetRootWindowResizerRect() const {
754 return gfx::Rect(); 754 return gfx::Rect();
755 } 755 }
756 756
757 void InterstitialPageImpl::CreateNewWindow( 757 void InterstitialPageImpl::CreateNewWindow(
758 int render_process_id, 758 SiteInstance* source_site_instance,
759 int route_id, 759 int route_id,
760 int main_frame_route_id, 760 int main_frame_route_id,
761 const ViewHostMsg_CreateWindow_Params& params, 761 const ViewHostMsg_CreateWindow_Params& params,
762 SessionStorageNamespace* session_storage_namespace) { 762 SessionStorageNamespace* session_storage_namespace) {
763 NOTREACHED() << "InterstitialPage does not support showing popups yet."; 763 NOTREACHED() << "InterstitialPage does not support showing popups yet.";
764 } 764 }
765 765
766 void InterstitialPageImpl::CreateNewWidget(int render_process_id, 766 void InterstitialPageImpl::CreateNewWidget(int render_process_id,
767 int route_id, 767 int route_id,
768 blink::WebPopupType popup_type) { 768 blink::WebPopupType popup_type) {
(...skipping 171 matching lines...) Expand 10 before | Expand all | Expand 10 after
940 void InterstitialPageImpl::UnderlyingContentObserver::NavigationEntryCommitted( 940 void InterstitialPageImpl::UnderlyingContentObserver::NavigationEntryCommitted(
941 const LoadCommittedDetails& load_details) { 941 const LoadCommittedDetails& load_details) {
942 interstitial_->OnNavigatingAwayOrTabClosing(); 942 interstitial_->OnNavigatingAwayOrTabClosing();
943 } 943 }
944 944
945 void InterstitialPageImpl::UnderlyingContentObserver::WebContentsDestroyed() { 945 void InterstitialPageImpl::UnderlyingContentObserver::WebContentsDestroyed() {
946 interstitial_->OnNavigatingAwayOrTabClosing(); 946 interstitial_->OnNavigatingAwayOrTabClosing();
947 } 947 }
948 948
949 } // namespace content 949 } // namespace content
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698