Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(534)

Unified Diff: sandbox/mac/os_compatibility.cc

Issue 1224283006: Update OS version functions for OS X 10.11 El Capitan. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: sandbox/mac/os_compatibility.cc
diff --git a/sandbox/mac/os_compatibility.cc b/sandbox/mac/os_compatibility.cc
index 6624f3a19be760740d8e1840287868e094b2a181..d1783c984f74a7542847099e8b18163893a9114c 100644
--- a/sandbox/mac/os_compatibility.cc
+++ b/sandbox/mac/os_compatibility.cc
@@ -120,7 +120,7 @@ const LaunchdCompatibilityShim GetLaunchdCompatibilityShim() {
shim.look_up2_get_request_name =
&LaunchdLookUp2GetRequestName<look_up2_request_10_6>;
} else if (base::mac::IsOSLionOrLater() &&
- !base::mac::IsOSYosemiteOrLater()) {
Andre 2015/07/15 21:33:32 I'm not sure about this. !IsOSYosemiteOrLater does
Robert Sesek 2015/07/15 21:44:45 This is checking for >= 10.7 && < 10.10.
Andre 2015/07/15 21:49:17 But why? Do we expect Yosemite and El Capitan to l
Robert Sesek 2015/07/15 21:50:26 This component needs to be updated for 10.10+ so i
Andre 2015/07/15 21:53:47 Got it. Fixed in patchset #2.
+ !base::mac::IsOSLaterThanElCapitan_DontCallThis()) {
shim.look_up2_get_request_name =
&LaunchdLookUp2GetRequestName<look_up2_request_10_7>;
} else {

Powered by Google App Engine
This is Rietveld 408576698