Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1921)

Issue 1224273008: bluetooth: android: Strings included in Chrome build. (Closed)

Created:
5 years, 5 months ago by scheib
Modified:
5 years, 5 months ago
Reviewers:
armansito, Nico
CC:
chromium-reviews, scheib+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@bta-discovery-2-
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

bluetooth: android: Strings included in Chrome build. Upcoming patch https://codereview.chromium.org/1215303006/ produces BluetoothDevices which may have empty names. Cross platform code BluetoothDevice::GetAddressWithLocalizedDeviceTypeName() generates names for devices that do not advertise a name and requires string resources. This patch packs bluetooth strings on all platforms except IOS (previously this was guarded by "enable_extensions"). Bluetooth string pak files in GN build are also made consistent with the GYP build (in a strings sub directory), as it was noticed that bluetooth was the only module inconsistent when comparing with: diff \ <(find outandroid/Debug -name "*pak" | sort) \ <(find outandroidgn/Debug/ -name "*pak" | sed s/gn// | sort) BUG=488579 Committed: https://crrev.com/6ceefd2e4a8a04218995580534479a0dbd328404 Cr-Commit-Position: refs/heads/master@{#338595}

Patch Set 1 : #

Patch Set 2 : GYP comment fix; Add OWNERS for .gn .gyp #

Patch Set 3 : Merge TOT #

Unified diffs Side-by-side diffs Delta from patch set Stats (+87 lines, -84 lines) Patch
M chrome/chrome_repack_locales.gni View 2 chunks +3 lines, -6 lines 0 comments Download
M chrome/chrome_resources.gyp View 1 4 chunks +9 lines, -9 lines 0 comments Download
M chrome/tools/build/repack_locales.py View 2 chunks +5 lines, -5 lines 0 comments Download
M device/bluetooth/BUILD.gn View 3 chunks +1 line, -64 lines 0 comments Download
A device/bluetooth/strings/BUILD.gn View 1 chunk +67 lines, -0 lines 0 comments Download
A device/bluetooth/strings/OWNERS View 1 1 chunk +2 lines, -0 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 22 (9 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1224273008/1
5 years, 5 months ago (2015-07-11 00:01:34 UTC) #2
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: linux_chromium_compile_dbg_32_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_compile_dbg_32_ng/builds/72299) mac_chromium_compile_dbg_ng on ...
5 years, 5 months ago (2015-07-11 00:07:18 UTC) #4
scheib
Splitting this change out from https://codereview.chromium.org/1215303006/ On 2015/07/09 20:47:55, Nico wrote: > On 2015/07/09 20:35:18, ...
5 years, 5 months ago (2015-07-11 00:11:43 UTC) #6
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1224273008/40001
5 years, 5 months ago (2015-07-11 00:24:18 UTC) #9
scheib
armansito, Review device/bluetooth/strings/OWNERS please.
5 years, 5 months ago (2015-07-11 00:28:45 UTC) #11
armansito
On 2015/07/11 00:28:45, scheib wrote: > armansito, Review device/bluetooth/strings/OWNERS please. TBH I don't even know ...
5 years, 5 months ago (2015-07-11 00:37:23 UTC) #12
scheib
On 2015/07/11 00:37:23, armansito wrote: > On 2015/07/11 00:28:45, scheib wrote: > > armansito, Review ...
5 years, 5 months ago (2015-07-11 00:38:20 UTC) #13
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 5 months ago (2015-07-11 02:01:12 UTC) #15
Nico
chrome lgtm
5 years, 5 months ago (2015-07-11 03:36:12 UTC) #16
armansito
lgtm
5 years, 5 months ago (2015-07-13 22:56:13 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1224273008/60001
5 years, 5 months ago (2015-07-13 23:27:23 UTC) #20
commit-bot: I haz the power
Committed patchset #3 (id:60001)
5 years, 5 months ago (2015-07-13 23:45:59 UTC) #21
commit-bot: I haz the power
5 years, 5 months ago (2015-07-13 23:47:03 UTC) #22
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/6ceefd2e4a8a04218995580534479a0dbd328404
Cr-Commit-Position: refs/heads/master@{#338595}

Powered by Google App Engine
This is Rietveld 408576698