Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(406)

Issue 1224273007: Revert of Remove adb_commands from android_browser_backend and android_browser_backend_settings. (Closed)

Created:
5 years, 5 months ago by dgozman
Modified:
5 years, 5 months ago
CC:
chromium-reviews, telemetry-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Remove adb_commands from android_browser_backend and android_browser_backend_settings. (patchset #6 id:100001 of https://codereview.chromium.org/1213423003/) Reason for revert: Speculative revert. Looks like this patch broke android bots with "AttributeError: 'WebviewShellBackendSettings' object has no attribute '_backend_settings'". See https://build.chromium.org/p/chromium.gpu/builders/Android%20Debug%20%28Nexus%205%29/builds/866. Original issue's description: > Remove adb_commands from android_browser_backend and android_browser_backend_settings. > > Pulled from https://codereview.chromium.org/1167173002/ > > BUG=476709 > > Committed: https://crrev.com/2e706aa8db5d0cfd09573ad56903868c4d8cd4ee > Cr-Commit-Position: refs/heads/master@{#338229} TBR=jbudorick@chromium.org,nednguyen@chromium.org,sullivan@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=476709 Committed: https://crrev.com/983ac23f007eb5bfb10f5516460998cbd18f388b Cr-Commit-Position: refs/heads/master@{#338276}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+89 lines, -120 lines) Patch
M tools/telemetry/telemetry/core/platform/android_platform_backend.py View 16 chunks +22 lines, -22 lines 0 comments Download
M tools/telemetry/telemetry/core/platform/android_platform_backend_unittest.py View 6 chunks +25 lines, -60 lines 0 comments Download
M tools/telemetry/telemetry/internal/backends/android_browser_backend_settings.py View 5 chunks +19 lines, -19 lines 0 comments Download
M tools/telemetry/telemetry/internal/backends/chrome/android_browser_backend.py View 7 chunks +20 lines, -18 lines 0 comments Download
M tools/telemetry/telemetry/internal/forwarders/android_forwarder.py View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
dgozman
Created Revert of Remove adb_commands from android_browser_backend and android_browser_backend_settings.
5 years, 5 months ago (2015-07-10 11:31:55 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1224273007/1
5 years, 5 months ago (2015-07-10 11:32:01 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 5 months ago (2015-07-10 11:32:59 UTC) #3
commit-bot: I haz the power
5 years, 5 months ago (2015-07-10 11:33:58 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/983ac23f007eb5bfb10f5516460998cbd18f388b
Cr-Commit-Position: refs/heads/master@{#338276}

Powered by Google App Engine
This is Rietveld 408576698