Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4528)

Unified Diff: chrome/browser/android/shortcut_info.cc

Issue 1224273003: webapps: propogate name and shortName from manifest to Java (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix test compile on Android Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/android/shortcut_info.cc
diff --git a/chrome/browser/android/shortcut_info.cc b/chrome/browser/android/shortcut_info.cc
index 67e0c5549c344667fdc39db4fc854bd8da65ea7d..e19fefd4ec39bb4b0187bc11aeb04c32a3fbb0e7 100644
--- a/chrome/browser/android/shortcut_info.cc
+++ b/chrome/browser/android/shortcut_info.cc
@@ -18,10 +18,15 @@ ShortcutInfo::ShortcutInfo(const GURL& shortcut_url)
}
void ShortcutInfo::UpdateFromManifest(const content::Manifest& manifest) {
- if (!manifest.short_name.is_null())
- title = manifest.short_name.string();
- else if (!manifest.name.is_null())
- title = manifest.name.string();
+ if (!manifest.name.is_null()) {
+ name = manifest.name.string();
+ user_title = name;
+ }
+
+ if (!manifest.short_name.is_null()) {
+ short_name = manifest.short_name.string();
+ user_title = short_name;
+ }
mlamouri (slow - plz ping) 2015/07/09 16:34:17 That means we might end up with short_name or name
// Set the url based on the manifest value, if any.
if (manifest.start_url.is_valid())
« chrome/browser/android/shortcut_helper.cc ('K') | « chrome/browser/android/shortcut_info.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698