chrome/browser/android/shortcut_helper.h - Issue 1224273003: webapps: propogate name and shortName from manifest to Java

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/android/shortcut_helper.h

Issue 1224273003: webapps: propogate name and shortName from manifest to Java (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix test compile on Android Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/android/java/src/org/chromium/chrome/browser/webapps/WebappInfo.java ('K') | « chrome/browser/android/shortcut_data_fetcher.cc ('k') | chrome/browser/android/shortcut_helper.cc » ('j') | chrome/browser/android/shortcut_helper.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/android/shortcut_helper.h

diff --git a/chrome/browser/android/shortcut_helper.h b/chrome/browser/android/shortcut_helper.h

index 9f872f29c9a052ec7749c488ad6eb0a467113557..7e302c3ed84b1338e05bd8d2cbe53f7db0b32d78 100644

--- a/chrome/browser/android/shortcut_helper.h

+++ b/chrome/browser/android/shortcut_helper.h

@@ -46,7 +46,7 @@ class ShortcutHelper : public ShortcutDataFetcher::Observer {

const SkBitmap& icon_bitmap);

// ShortcutDataFetcher::Observer

- void OnTitleAvailable(const base::string16& title) override;

+ void OnUserTitleAvailable(const base::string16& user_title) override;

void OnDataAvailable(const ShortcutInfo& info, const SkBitmap& icon) override;

SkBitmap FinalizeLauncherIcon(const SkBitmap& icon, const GURL& url) override;