chrome/android/javatests/src/org/chromium/chrome/browser/webapps/WebappVisibilityTest.java - Issue 1224273003: webapps: propogate name and shortName from manifest to Java

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/javatests/src/org/chromium/chrome/browser/webapps/WebappVisibilityTest.java

Issue 1224273003: webapps: propogate name and shortName from manifest to Java (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix test compile on Android Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/android/java/src/org/chromium/chrome/browser/webapps/WebappInfo.java ('K') | « chrome/android/javatests/src/org/chromium/chrome/browser/webapps/WebappUrlBarTest.java ('k') | chrome/android/javatests_shell/src/org/chromium/chrome/browser/ShortcutHelperTest.java » ('j') | chrome/browser/android/shortcut_helper.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/javatests/src/org/chromium/chrome/browser/webapps/WebappVisibilityTest.java

diff --git a/chrome/android/javatests/src/org/chromium/chrome/browser/webapps/WebappVisibilityTest.java b/chrome/android/javatests/src/org/chromium/chrome/browser/webapps/WebappVisibilityTest.java

index 38e90855a2ab8d3c86c0834f65aab5726afbcd07..75b281716050f3122fa9dd818de8fb4495bdf2e5 100644

--- a/chrome/android/javatests/src/org/chromium/chrome/browser/webapps/WebappVisibilityTest.java

+++ b/chrome/android/javatests/src/org/chromium/chrome/browser/webapps/WebappVisibilityTest.java

@@ -19,7 +19,7 @@ public class WebappVisibilityTest extends WebappActivityTestBase {

@Feature({"Webapps"})

public void testShouldShowTopControls() {

final String webappUrl = "http://originalwebsite.com";

- WebappInfo mockInfo = WebappInfo.create(WEBAPP_ID, webappUrl,

+ WebappInfo mockInfo = WebappInfo.create(WEBAPP_ID, webappUrl, null,

null, null, ScreenOrientationValues.DEFAULT, ShortcutHelper.SOURCE_UNKNOWN);

getActivity().getWebappInfo().copy(mockInfo);