webapps: propogate name and shortName from manifest to Java

chrome/android/java/src/org/chromium/chrome/browser/document/ChromeLauncherActivity.java

Index: chrome/android/java/src/org/chromium/chrome/browser/document/ChromeLauncherActivity.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/document/ChromeLauncherActivity.java b/chrome/android/java/src/org/chromium/chrome/browser/document/ChromeLauncherActivity.java
index 96e1193c0848435865e65f031e7e2b6c35374064..e945867b5e2d59a0dbe196a7cb72c5ebc96556b6 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/document/ChromeLauncherActivity.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/document/ChromeLauncherActivity.java
@@ -770,13 +770,21 @@ public class ChromeLauncherActivity extends Activity
     private Intent launchWebapp(Intent intent) {
         String webappId = IntentUtils.safeGetStringExtra(intent, ShortcutHelper.EXTRA_ID);
         String webappUrl = IntentUtils.safeGetStringExtra(intent, ShortcutHelper.EXTRA_URL);
-        String webappTitle = IntentUtils.safeGetStringExtra(intent, ShortcutHelper.EXTRA_TITLE);
         String webappIcon = IntentUtils.safeGetStringExtra(intent, ShortcutHelper.EXTRA_ICON);
         int webappOrientation = IntentUtils.safeGetIntExtra(intent,
                 ShortcutHelper.EXTRA_ORIENTATION, ScreenOrientationValues.DEFAULT);
         int webappSource = IntentUtils.safeGetIntExtra(intent,
                 ShortcutHelper.EXTRA_SOURCE, ShortcutHelper.SOURCE_UNKNOWN);
 

[mlamouri (slow - plz ping), 2015/07/09 16:34:17]

nit: remove empty line

+        String webappName = IntentUtils.safeGetStringExtra(intent,
+                ShortcutHelper.EXTRA_NAME);
+        String webappShortName = IntentUtils.safeGetStringExtra(intent,
+                ShortcutHelper.EXTRA_SHORT_NAME);
+
+        String webappTitle = IntentUtils.safeGetStringExtra(intent, ShortcutHelper.EXTRA_TITLE);

[mlamouri (slow - plz ping), 2015/07/09 16:34:17]

nit: add comment explaining this is for backward compatibility. 

+        webappShortName = webappShortName == null ? webappTitle : webappShortName;
+        webappName = webappName == null ? webappShortName : webappName;
+
         if (webappId != null && webappUrl != null) {
             String webappMacString = IntentUtils.safeGetStringExtra(
                     intent, ShortcutHelper.EXTRA_MAC);
@@ -789,8 +797,8 @@ public class ChromeLauncherActivity extends Activity
                             webappUrl, webappSource);
                 }
 
-                WebappActivity.launchInstance(this, webappId,
-                        webappUrl, webappIcon, webappTitle, webappOrientation, webappSource);
+                WebappActivity.launchInstance(this, webappId, webappUrl,
+                        webappIcon, webappName, webappShortName, webappOrientation, webappSource);
             } else {
                 Log.e(TAG, "Shortcut (" + webappUrl + ") opened in Chrome.");