chrome/android/java/src/org/chromium/chrome/browser/webapps/FullScreenActivityTab.java - Issue 1224273003: webapps: propogate name and shortName from manifest to Java

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/webapps/FullScreenActivityTab.java

Issue 1224273003: webapps: propogate name and shortName from manifest to Java (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Add back explict destructor Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/webapps/AddToHomescreenDialog.java ('k') | chrome/android/java/src/org/chromium/chrome/browser/webapps/WebappActivity.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/webapps/FullScreenActivityTab.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/webapps/FullScreenActivityTab.java b/chrome/android/java/src/org/chromium/chrome/browser/webapps/FullScreenActivityTab.java

index 8ac3a7d514a0f7907b9135e5f1aa7317c7e05b37..38393ff16802e01194190cf06f732bba5d063871 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/webapps/FullScreenActivityTab.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/webapps/FullScreenActivityTab.java

@@ -324,7 +324,8 @@ public class FullScreenActivityTab extends ChromeTab {

intent.putExtra(ShortcutHelper.EXTRA_ICON, webAppInfo.getEncodedIcon());

intent.putExtra(ShortcutHelper.EXTRA_ID, webAppInfo.id());

intent.putExtra(ShortcutHelper.EXTRA_URL, url);

- intent.putExtra(ShortcutHelper.EXTRA_TITLE, webAppInfo.title());

+ intent.putExtra(ShortcutHelper.EXTRA_NAME, webAppInfo.name());

+ intent.putExtra(ShortcutHelper.EXTRA_SHORT_NAME, webAppInfo.shortName());

intent.putExtra(ShortcutHelper.EXTRA_ORIENTATION, webAppInfo.orientation());

intent.putExtra(ShortcutHelper.EXTRA_MAC, ShortcutHelper.getEncodedMac(mActivity, url));

intent.putExtra(ShortcutHelper.EXTRA_SOURCE, webAppInfo.source());