Refactor browser side navigator.connect code to not use MessagePortService.

Refactor browser side navigator.connect code to not use MessagePortService.

This is the first step towards unifying client side and service side ServicePort
instances, but also removes a layer of abstraction in how connections to
services are setup. The abstraction layer will probably later be reintroduced
differently.

BUG=426458
Committed: https://crrev.com/9b053ed8f7b8893ad0a5a33d31546c70563ddf20
Cr-Commit-Position: refs/heads/master@{#341987}

Committed: https://crrev.com/2c37231d9a17c30669d5286742159661b95eb7eb
Cr-Commit-Position: refs/heads/master@{#342374}

[Marijn Kruisselbrink, 2015-08-03 21:36:14]

Patchset #1 (id:1) has been deleted

[Marijn Kruisselbrink, 2015-08-03 21:38:33]

Patchset #1 (id:20001) has been deleted

[Marijn Kruisselbrink, 2015-08-04 17:01:00]

mek@chromium.org changed reviewers:
+ bsittler@chromium.org

[bsittler, 2015-08-04 22:28:14]

lgtm

[Marijn Kruisselbrink, 2015-08-04 22:29:50]

mek@chromium.org changed reviewers:
+ avi@chromium.org

[Marijn Kruisselbrink, 2015-08-04 22:29:51]

+avi for content/browser/storage_partition_impl.cc OWNERS

[Avi (use Gerrit), 2015-08-05 15:17:20]

lgtm

comment fixes only

https://codereview.chromium.org/1224263007/diff/40001/content/browser/navigat...
File content/browser/navigator_connect/navigator_connect_context_impl.cc
(right):

https://codereview.chromium.org/1224263007/diff/40001/content/browser/navigat...
content/browser/navigator_connect/navigator_connect_context_impl.cc:107: //
message
re-wrap this comment block

https://codereview.chromium.org/1224263007/diff/40001/content/browser/navigat...
File content/browser/navigator_connect/navigator_connect_context_impl.h (left):

https://codereview.chromium.org/1224263007/diff/40001/content/browser/navigat...
content/browser/navigator_connect/navigator_connect_context_impl.h:17: #endif
Is being able to do this a consequence of removing windows.h from the
precompiled header file? Yay! 🎉

https://codereview.chromium.org/1224263007/diff/40001/content/browser/navigat...
File content/browser/navigator_connect/navigator_connect_context_impl.h (right):

https://codereview.chromium.org/1224263007/diff/40001/content/browser/navigat...
content/browser/navigator_connect/navigator_connect_context_impl.h:53: // Called
when a message is send to a ServicePort. The |sender_port_id| is the
s/send/sent/

https://codereview.chromium.org/1224263007/diff/40001/content/browser/navigat...
content/browser/navigator_connect/navigator_connect_context_impl.h:76: // failed
to locate) for a connection attempt.
... has been located (or has failed to be located) for ...

[Marijn Kruisselbrink, 2015-08-05 17:00:16]

https://codereview.chromium.org/1224263007/diff/40001/content/browser/navigat...
File content/browser/navigator_connect/navigator_connect_context_impl.cc
(right):

https://codereview.chromium.org/1224263007/diff/40001/content/browser/navigat...
content/browser/navigator_connect/navigator_connect_context_impl.cc:107: //
message
On 2015/08/05 at 15:17:20, Avi wrote:
> re-wrap this comment block

Done

https://codereview.chromium.org/1224263007/diff/40001/content/browser/navigat...
File content/browser/navigator_connect/navigator_connect_context_impl.h (left):

https://codereview.chromium.org/1224263007/diff/40001/content/browser/navigat...
content/browser/navigator_connect/navigator_connect_context_impl.h:17: #endif
On 2015/08/05 at 15:17:20, Avi wrote:
> Is being able to do this a consequence of removing windows.h from the
precompiled header file? Yay! 🎉

I think in this case it is just the case that this file on longer has a
SendMessage method, but yeah, hopefully some of the other places of similar
defines are no longer needed now anymore either.

https://codereview.chromium.org/1224263007/diff/40001/content/browser/navigat...
File content/browser/navigator_connect/navigator_connect_context_impl.h (right):

https://codereview.chromium.org/1224263007/diff/40001/content/browser/navigat...
content/browser/navigator_connect/navigator_connect_context_impl.h:53: // Called
when a message is send to a ServicePort. The |sender_port_id| is the
On 2015/08/05 at 15:17:20, Avi wrote:
> s/send/sent/

Done

https://codereview.chromium.org/1224263007/diff/40001/content/browser/navigat...
content/browser/navigator_connect/navigator_connect_context_impl.h:76: // failed
to locate) for a connection attempt.
On 2015/08/05 at 15:17:20, Avi wrote:
> ... has been located (or has failed to be located) for ...

Done

[Marijn Kruisselbrink, 2015-08-05 17:00:19]

The CQ bit was checked by mek@chromium.org

[Marijn Kruisselbrink, 2015-08-05 17:00:20]

The patchset sent to the CQ was uploaded after l-g-t-m from
bsittler@chromium.org, avi@chromium.org
Link to the patchset: https://codereview.chromium.org/1224263007/#ps60001
(title: "comment fixes")

[commit-bot: I haz the power, 2015-08-05 17:00:41]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1224263007/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1224263007/60001

[commit-bot: I haz the power, 2015-08-05 17:25:30]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-08-05 17:25:31]

Try jobs failed on following builders:
  win_chromium_x64_rel_ng on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[Marijn Kruisselbrink, 2015-08-05 17:27:42]

The CQ bit was checked by mek@chromium.org

[commit-bot: I haz the power, 2015-08-05 17:28:33]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1224263007/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1224263007/60001

[commit-bot: I haz the power, 2015-08-05 17:41:35]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-08-05 17:41:35]

Try jobs failed on following builders:
  win_chromium_compile_dbg_ng on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_comp...)

[Marijn Kruisselbrink, 2015-08-05 18:18:34]

The CQ bit was checked by mek@chromium.org

[commit-bot: I haz the power, 2015-08-05 18:18:55]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1224263007/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1224263007/60001

[commit-bot: I haz the power, 2015-08-05 21:12:13]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-08-05 21:12:14]

Try jobs failed on following builders:
  win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[Marijn Kruisselbrink, 2015-08-05 21:12:55]

The CQ bit was checked by mek@chromium.org

[commit-bot: I haz the power, 2015-08-05 21:14:37]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1224263007/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1224263007/60001

[commit-bot: I haz the power, 2015-08-05 22:19:30]

Committed patchset #2 (id:60001)

[commit-bot: I haz the power, 2015-08-05 22:20:13]

Patchset 2 (id:??) landed as
https://crrev.com/9b053ed8f7b8893ad0a5a33d31546c70563ddf20
Cr-Commit-Position: refs/heads/master@{#341987}

[Marijn Kruisselbrink, 2015-08-06 00:29:05]

A revert of this CL (patchset #2 id:60001) has been created in
https://codereview.chromium.org/1278483004/ by mek@chromium.org.

The reason for reverting is: Seems to be crashing on windows.

BUG=517281
.

[Marijn Kruisselbrink, 2015-08-07 03:18:57]

The CQ bit was checked by mek@chromium.org

[Marijn Kruisselbrink, 2015-08-07 03:18:58]

The patchset sent to the CQ was uploaded after l-g-t-m from
bsittler@chromium.org, avi@chromium.org
Link to the patchset: https://codereview.chromium.org/1224263007/#ps80001
(title: "fix uninitialized variable")

[commit-bot: I haz the power, 2015-08-07 03:19:33]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1224263007/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1224263007/80001

[Marijn Kruisselbrink, 2015-08-07 03:25:23]

The CQ bit was unchecked by mek@chromium.org

[Marijn Kruisselbrink, 2015-08-07 16:57:07]

The CQ bit was checked by mek@chromium.org

[Marijn Kruisselbrink, 2015-08-07 16:57:07]

The patchset sent to the CQ was uploaded after l-g-t-m from
bsittler@chromium.org, avi@chromium.org
Link to the patchset: https://codereview.chromium.org/1224263007/#ps100001
(title: "fix merge conflict")

[commit-bot: I haz the power, 2015-08-07 16:57:23]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1224263007/100001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1224263007/100001

[commit-bot: I haz the power, 2015-08-07 17:35:36]

Committed patchset #4 (id:100001)

[commit-bot: I haz the power, 2015-08-07 17:36:10]

Patchset 4 (id:??) landed as
https://crrev.com/2c37231d9a17c30669d5286742159661b95eb7eb
Cr-Commit-Position: refs/heads/master@{#342374}