Fix test failures from AnimatedContainer patch.

Fix test failures from AnimatedContainer patch.
- Needed to move properties into AnimatedContainer to create a full BoxDecoration.
- Updated test expectations because backgroundColor animates now.

R=abarth@chromium.org

Committed: https://chromium.googlesource.com/external/mojo/+/8e0b6ac898ff213e820eedbcfcc83c983181cf87

[Matt Perry, 2015-07-09 19:17:20]

mpcomplete@chromium.org changed reviewers:
+ abarth@chromium.org

[Matt Perry, 2015-07-09 19:17:21]

https://codereview.chromium.org/1224223004/diff/1/sky/sdk/lib/widgets/materia...
File sky/sdk/lib/widgets/material.dart (right):

https://codereview.chromium.org/1224223004/diff/1/sky/sdk/lib/widgets/materia...
sky/sdk/lib/widgets/material.dart:39: ..backgroundColor = new
AnimatedColor(_getBackgroundColor(type, color))
One thing I'm worried about here: do we create a new widget when the theme
changes? If not (if we just call build() again), backgroundColor won't get
updated properly.

[abarth-chromium, 2015-07-09 19:19:00]

lgtm

https://codereview.chromium.org/1224223004/diff/1/sky/sdk/lib/widgets/materia...
File sky/sdk/lib/widgets/material.dart (right):

https://codereview.chromium.org/1224223004/diff/1/sky/sdk/lib/widgets/materia...
sky/sdk/lib/widgets/material.dart:39: ..backgroundColor = new
AnimatedColor(_getBackgroundColor(type, color))
On 2015/07/09 at 19:17:21, Matt Perry wrote:
> One thing I'm worried about here: do we create a new widget when the theme
changes? If not (if we just call build() again), backgroundColor won't get
updated properly.

We create a new widget.

[Matt Perry, 2015-07-09 19:26:43]

Committed patchset #3 (id:40001) manually as
8e0b6ac898ff213e820eedbcfcc83c983181cf87 (presubmit successful).

[Hixie, 2015-07-09 20:58:39]

ianh@google.com changed reviewers:
+ ianh@google.com

[Hixie, 2015-07-09 20:58:40]

What's the delta of the tests from before your initial change to after this
change?

https://codereview.chromium.org/1224223004/diff/40001/sky/sdk/lib/widgets/mat...
File sky/sdk/lib/widgets/material.dart (right):

https://codereview.chromium.org/1224223004/diff/40001/sky/sdk/lib/widgets/mat...
sky/sdk/lib/widgets/material.dart:34: if (level == null) level = 0;
This constructor is getting out of control. Widget constructors have to be
super-cheap because we run them every frame. We need a better solution here.

[Matt Perry, 2015-07-09 21:03:13]

https://codereview.chromium.org/1224223004/diff/40001/sky/sdk/lib/widgets/mat...
File sky/sdk/lib/widgets/material.dart (right):

https://codereview.chromium.org/1224223004/diff/40001/sky/sdk/lib/widgets/mat...
sky/sdk/lib/widgets/material.dart:34: if (level == null) level = 0;
On 2015/07/09 20:58:40, Hixie wrote:
> This constructor is getting out of control. Widget constructors have to be
> super-cheap because we run them every frame. We need a better solution here.

Is there a method that gets called after construction when we know we're going
to keep a Widget?

Though, if we're worried about the cost of constructing new objects each frame,
is this really much worse than before? The entire Widget hierarchy gets rebuilt
when Widget.build is called.