src/IceRegistersX8664.h - Issue 1224173006: Adds the x86-64 assembler.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/IceRegistersX8664.h

Issue 1224173006: Adds the x86-64 assembler. (Closed) Base URL: https://chromium.googlesource.com/native_client/pnacl-subzero.git@master

Patch Set: Addresses comments; changes emitRex.* logic. Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/IceRegistersX8664.h

diff --git a/src/IceRegistersX8664.h b/src/IceRegistersX8664.h

index 3e4c868ddfbb5898125bc5a88a9d832883cebc0c..4069e229362207d989e21483af39f745c2d27fde 100644

--- a/src/IceRegistersX8664.h

+++ b/src/IceRegistersX8664.h

@@ -79,6 +79,7 @@ public:

}

static inline ByteRegister getEncodedByteReg(int32_t RegNum) {

+ assert(RegNum != Encoded_Reg_spl && "spl cannot be used. no exceptions.");

// In x86-64, AH is not encodable when the REX prefix is used; the same

// encoding is used for spl. Therefore, ah needs special handling.

if (RegNum == Reg_ah)

John 2015/07/27 20:35:58 This is not going to work for X86-64. Accessing AH

« no previous file with comments | « src/IceInstX8664.def ('k') | src/IceTargetLoweringX8632Traits.h » ('j') | no next file with comments »